feat(json-rpc): initial package by ludamad · Pull Request #2 · AztecProtocol/aztec-packages

ludamad · 2023-03-01T19:57:40Z

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

I have reviewed my diff in github, line by line.
Every change is related to the PR description.
I have linked this pull request to the issue(s) that it resolves.
There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
The branch has been rebased against the head of its merge target.
I'm happy for the PR to be merged at the reviewer's next convenience.

LeilaWang · 2023-03-07T14:05:05Z

yarn-project/json-rpc/README.md

+
+```
+const wallet = new JsonRpcClient<WalletImplementation>('wallet-server.com', /*register classes*/ {PublicKey, TxRequest});
+const response = await wallet.rpc.signTxRequest(accountPubKey, txRequest);


Can we make it call the methods directly from the client: wallet.signTxRequest?

Sorta. You need a proxy object to do this, I don't think you can do new ... and have something end up a proxy object. If we instead had a createRpcClient function we could do it. It could just return the .rpc object

…at/json-rpc

Report diff in comment

Overview: If you are in a scenario where you have a failing call to check_circuit and wish to get more information out of it than just the gate index, you can use this feature to get a stack trace, see example below. Usage instructions: - On ubuntu (or our mainframe accounts) use `sudo apt-get install libdw-dev` to support trace printing - Use `cmake --preset clang16-dbg-fast-circuit-check-traces` and `cmake --build --preset clang16-dbg-fast-circuit-check-traces` to enable the backward-cpp dependency through the CHECK_CIRCUIT_STACKTRACES CMake variable. - Run any case where you have a failing check_circuit call, you will now have a stack trace illuminating where this constraint was added in code. Caveats: - This works best for code that is not overly generic, i.e. where just the sequence of function calls carries a lot of information. It is possible to tag extra data along with the stack trace, this can be done as a followup, please leave feedback if desired. - There are certain functions like `assert_equals` that can cause gates that occur _before_ them to fail. If this would be useful to automatically report, please leave feedback. Example: ``` [ RUN ] standard_circuit_constructor.test_check_circuit_broken Stack trace (most recent call last): #4 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2845, in Run 2842: if (!Test::HasFatalFailure() && !Test::IsSkipped()) { 2843: // This doesn't throw as all user code that can throw are wrapped into 2844: // exception handling code. >2845: test->Run(); 2846: } 2847: 2848: if (test != nullptr) { #3 Source "_deps/gtest-src/googletest/src/gtest.cc", line 2696, in Run 2693: // GTEST_SKIP(). 2694: if (!HasFatalFailure() && !IsSkipped()) { 2695: impl->os_stack_trace_getter()->UponLeavingGTest(); >2696: internal::HandleExceptionsInMethodIfSupported(this, &Test::TestBody, 2697: "the test body"); 2698: } #2 | Source "_deps/gtest-src/googletest/src/gtest.cc", line 2657, in HandleSehExceptionsInMethodIfSupported<testing::Test, void> | 2655: #if GTEST_HAS_EXCEPTIONS | 2656: try { | >2657: return HandleSehExceptionsInMethodIfSupported(object, method, location); | 2658: } catch (const AssertionException&) { // NOLINT | 2659: // This failure was reported already. Source "_deps/gtest-src/googletest/src/gtest.cc", line 2621, in HandleExceptionsInMethodIfSupported<testing::Test, void> 2618: } 2619: #else 2620: (void)location; >2621: return (object->*method)(); 2622: #endif // GTEST_HAS_SEH 2623: } #1 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/circuit_checker/standard_circuit_builder.test.cpp", line 464, in TestBody 461: uint32_t d_idx = circuit_constructor.add_variable(d); 462: circuit_constructor.create_add_gate({ a_idx, b_idx, c_idx, fr::one(), fr::one(), fr::neg_one(), fr::zero() }); 463: > 464: circuit_constructor.create_add_gate({ d_idx, c_idx, a_idx, fr::one(), fr::neg_one(), fr::neg_one(), fr::zero() }); 465: 466: bool result = CircuitChecker::check(circuit_constructor); 467: EXPECT_EQ(result, false); #0 Source "/mnt/user-data/adam/aztec-packages/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.cpp", line 22, in create_add_gate 19: { 20: this->assert_valid_variables({ in.a, in.b, in.c }); 21: > 22: blocks.arithmetic.populate_wires(in.a, in.b, in.c); 23: blocks.arithmetic.q_m().emplace_back(FF::zero()); 24: blocks.arithmetic.q_1().emplace_back(in.a_scaling); 25: blocks.arithmetic.q_2().emplace_back(in.b_scaling); gate number4 ```

Should fix some flake in kind network smoke. Key was the following logs I found in a failing run: ``` spartan-aztec-network-boot-node-0 deploy-create2-deployer Error: spartan-aztec-network-boot-node-0 deploy-create2-deployer error sending request for url (http://spartan-aztec-network-ethereum.smoke:8545/) spartan-aztec-network-boot-node-0 deploy-create2-deployer spartan-aztec-network-boot-node-0 deploy-create2-deployer Context: spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #0: error sending request for url (http://spartan-aztec-network-ethereum.smoke:8545/) spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #1: client error (Connect) spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #2: dns error: failed to lookup address information: Name does not resolve spartan-aztec-network-boot-node-0 deploy-create2-deployer - Error #3: failed to lookup address information: Name does not resolve ```

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

BEGIN_COMMIT_OVERRIDE fix: Origin Tags edgecase (#16921) chore: cycle group cleanup #2 (#16876) chore: civc tidy 3 (#16671) refactor(bb): optimize batch_mul_with_endomorphism (#16905) feat: check op queue wires are zero past minicircuit in Translator (#16858) feat: Add CPU scaling benchmark script for remote execution (#16918) fix: Add free witness tag to field constructor (#16827) fix(bb): darwin build (#16957) END_COMMIT_OVERRIDE

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

added missing bb methods

Cleanup and minor performance related bugfixes for `cycle_group::_variable_base_batch_mul_internal()` - Utilize native hints in stdlib straus lookup table construction where they were erroneously not being used before - remove duplicate construction of native straus lookup tables (see PR comments for more details) - virtually every instance of `emplace_back` was being used incorrectly - remove `std::optional` logic associated with broken support for scalars of different sizes (now protected with an assert)

…scripts - Fix setup-nightly-sandbox.sh to compile both side_effect and parent contracts (correct directory layout, dependency path fixup via sed) - Trim verbose comments across side_effect machine and main.rs tests - Consolidate repeated authwit_nonce comments in token system - Remove stale TODO in token machine check_result - Add repro scripts for issue #1 (nullifier inclusion) and #2 (DestroyNote ordering) — issue #2 confirmed not reproduced - Update contract artifacts from fresh nightly build Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ludamad0 added 7 commits March 1, 2023 14:57

feat(json-rpc): sketch of package

e8a4304

feat(json-rpc): working minimal test

d9cbe79

feat(json-rpc): cleaner test

b148562

feat(json-rpc): add, and appease, client tests

b851fd9

feat(json-rpc): add Buffer support

cd1ba73

chore: revert .vscode

ce711b9

chore: update Dockerfile

69103ef

ludamad marked this pull request as ready for review March 2, 2023 13:24

ludamad changed the title ~~feat(json-rpc): sketch of package~~ feat(json-rpc): initial package Mar 2, 2023

feat(json-rpc): test buffer support

4d63973

LeilaWang changed the base branch from stage to dev March 2, 2023 15:59

feat(json-rpc): move to snake-case

4ecaa69

LeilaWang reviewed Mar 7, 2023

View reviewed changes

ludamad0 added 8 commits March 7, 2023 09:57

feat(json-rpc): make client a proxy object

d893c72

feat(json-rpc): make client a proxy object

8993260

Merge remote-tracking branch 'origin/adam/feat/json-rpc' into adam/fe…

7276421

…at/json-rpc

Revert .vscode

0acff43

chore: remove comment

353cea6

Merge branch 'master' into adam/feat/json-rpc

03827fe

Merge remote-tracking branch 'origin/master' into adam/feat/json-rpc

156b7f1

docs: Documentation pass

6be3fef

LeilaWang mentioned this pull request Mar 15, 2023

Provide an HTTPAztecRPCClient that connects to an HTTP server. #52

Closed

ludamad closed this Mar 21, 2023

charlielye deleted the adam/feat/json-rpc branch March 28, 2023 21:20

ludamad pushed a commit that referenced this pull request Apr 14, 2023

contract deployment data generator (#2)

11a8549

ludamad pushed a commit that referenced this pull request Apr 17, 2023

contract deployment data generator (#2)

7171574

ludamad pushed a commit that referenced this pull request Apr 17, 2023

contract deployment data generator (#2)

2b159f3

spalladino mentioned this pull request Jul 26, 2023

[ci] Should git-subrepo commits be squashed/in side-history? #1190

Closed

ludamad added a commit that referenced this pull request Apr 5, 2024

Merge pull request #2 from ludamad-test-org/report-diff-in-comment

cc829af

Report diff in comment

guipublic added a commit that referenced this pull request Jun 3, 2024

fix merge issues #2

c156522

ludamad mentioned this pull request Jun 4, 2024

feat(bb): stack traces for check_circuit #6851

Merged

lucasxia01 added a commit that referenced this pull request Sep 2, 2024

attempt #2

41e5441

aminsammara added a commit that referenced this pull request Mar 12, 2025

CI fixes #2

4e2cb0a

iakovenkos mentioned this pull request Aug 6, 2025

chore: resolve field_t issues from external audit #16210

Merged

dbanks12 mentioned this pull request Aug 12, 2025

feat!: constrain discarding of side-effects for tx-level operations in AVM #16258

Merged

AztecBot mentioned this pull request Sep 10, 2025

feat: merge-train/barretenberg #16928

Merged

iakovenkos mentioned this pull request Oct 22, 2025

chore: stdlib byte_array and bool external audit fixes #17838

Merged

ludamad pushed a commit that referenced this pull request Dec 3, 2025

Merge pull request #2 from zkpassport/pr/additional-bb-methods

0b8f3c0

added missing bb methods

iakovenkos mentioned this pull request Jan 8, 2026

chore: transcript+codec+poseidon2 fixes #19419

Merged

chrismarino added a commit to chrismarino/aztec-packages that referenced this pull request Feb 1, 2026

Update for clarity on question AztecProtocol#2.

40bcbb1

AztecBot mentioned this pull request Mar 13, 2026

Archiver data integrity and reorg safety #21497

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(json-rpc): initial package#2

feat(json-rpc): initial package#2
ludamad wants to merge 17 commits intomasterfrom
adam/feat/json-rpc

ludamad commented Mar 1, 2023 •

edited

Loading

Uh oh!

LeilaWang Mar 7, 2023

Uh oh!

ludamad Mar 7, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ludamad commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist:

Uh oh!

LeilaWang Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

ludamad Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ludamad commented Mar 1, 2023 •

edited

Loading

ludamad Mar 7, 2023 •

edited

Loading