fix: Add free witness tag to field constructor#16827
Merged
Rumata888 merged 1 commit intomerge-train/barretenbergfrom Sep 11, 2025
Merged
fix: Add free witness tag to field constructor#16827Rumata888 merged 1 commit intomerge-train/barretenbergfrom
Rumata888 merged 1 commit intomerge-train/barretenbergfrom
Conversation
Rumata888
force-pushed
the
is/add_free_witness_to_field
branch
from
c4a3399 to
b4a401f
Compare
ledwards2225
approved these changes
Sep 9, 2025
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
LG - just a request for more detailed comment in the transcript
| } | ||
|
|
||
| // In case the transcript is used for recursive verification, we need to sanitize current round data so we don't | ||
| // get an origin tag violation inside the hasher |
Contributor
There was a problem hiding this comment.
Can you elaborate a little more on why this is necessary?
Contributor
Author
There was a problem hiding this comment.
Hopefully, I'll be able to remove this soon, as there are some other PRs that just assign tags properly to the buffer
Rumata888
force-pushed
the
is/add_free_witness_to_field
branch
from
b4a401f to
3e393d6
Compare
Rumata888
force-pushed
the
is/add_free_witness_to_field
branch
from
3e393d6 to
9fe1729
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
BEGIN_COMMIT_OVERRIDE fix: Origin Tags edgecase (#16921) chore: cycle group cleanup #2 (#16876) chore: civc tidy 3 (#16671) refactor(bb): optimize batch_mul_with_endomorphism (#16905) feat: check op queue wires are zero past minicircuit in Translator (#16858) feat: Add CPU scaling benchmark script for remote execution (#16918) fix: Add free witness tag to field constructor (#16827) fix(bb): darwin build (#16957) END_COMMIT_OVERRIDE
Umarb97
pushed a commit
to Umarb97/aztec-packages
that referenced
this pull request
Sep 16, 2025
Missed setting free witness in one of constructors before
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Missed setting free witness in one of constructors before
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Missed setting free witness in one of constructors before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed setting free witness in one of constructors before