Skip to content

refactor(bb): optimize batch_mul_with_endomorphism#16905

Merged
ludamad merged 6 commits intomerge-train/barretenbergfrom
ad/threads
Sep 10, 2025
Merged

refactor(bb): optimize batch_mul_with_endomorphism#16905
ludamad merged 6 commits intomerge-train/barretenbergfrom
ad/threads

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 9, 2025

The thread scaling behaviour was a lot better just having a consistent internal loop, operating on a range of the problem at a time

Before
Screenshot 2025-09-09 at 5 41 46 PM

After
Screenshot 2025-09-09 at 5 42 01 PM

@ludamad ludamad added the T-optimisation Type: Optimisation. Making something faster / cheaper / smaller label Sep 9, 2025
@ludamad ludamad changed the base branch from next to merge-train/barretenberg September 10, 2025 14:08
@ludamad ludamad removed the T-optimisation Type: Optimisation. Making something faster / cheaper / smaller label Sep 10, 2025
Copy link
Contributor

@johnathan79717 johnathan79717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think it's worth checking whether some helpers can be inline to improve readability before merging.

@ludamad ludamad merged commit e547996 into merge-train/barretenberg Sep 10, 2025
6 checks passed
@ludamad ludamad deleted the ad/threads branch September 10, 2025 20:19
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2025
BEGIN_COMMIT_OVERRIDE
fix: Origin Tags edgecase (#16921)
chore: cycle group cleanup #2 (#16876)
chore: civc tidy 3 (#16671)
refactor(bb): optimize batch_mul_with_endomorphism (#16905)
feat: check op queue wires are zero past minicircuit in Translator
(#16858)
feat: Add CPU scaling benchmark script for remote execution (#16918)
fix: Add free witness tag to field constructor (#16827)
fix(bb): darwin build (#16957)
END_COMMIT_OVERRIDE
Umarb97 pushed a commit to Umarb97/aztec-packages that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants