refactor(bb): optimize batch_mul_with_endomorphism#16905
Merged
ludamad merged 6 commits intomerge-train/barretenbergfrom Sep 10, 2025
Merged
refactor(bb): optimize batch_mul_with_endomorphism#16905ludamad merged 6 commits intomerge-train/barretenbergfrom
ludamad merged 6 commits intomerge-train/barretenbergfrom
Conversation
johnathan79717
approved these changes
Sep 10, 2025
Contributor
johnathan79717
left a comment
There was a problem hiding this comment.
LGTM but I think it's worth checking whether some helpers can be inline to improve readability before merging.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
BEGIN_COMMIT_OVERRIDE fix: Origin Tags edgecase (#16921) chore: cycle group cleanup #2 (#16876) chore: civc tidy 3 (#16671) refactor(bb): optimize batch_mul_with_endomorphism (#16905) feat: check op queue wires are zero past minicircuit in Translator (#16858) feat: Add CPU scaling benchmark script for remote execution (#16918) fix: Add free witness tag to field constructor (#16827) fix(bb): darwin build (#16957) END_COMMIT_OVERRIDE
Umarb97
pushed a commit
to Umarb97/aztec-packages
that referenced
this pull request
Sep 16, 2025
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
ludamad
added a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread scaling behaviour was a lot better just having a consistent internal loop, operating on a range of the problem at a time
Before

After
