Skip to content

chore: update naming in bb_proof_verification lib#18269

Merged
ledwards2225 merged 1 commit intomerge-train/barretenbergfrom
lde/verification-lib-naming
Nov 7, 2025
Merged

chore: update naming in bb_proof_verification lib#18269
ledwards2225 merged 1 commit intomerge-train/barretenbergfrom
lde/verification-lib-naming

Conversation

@ledwards2225
Copy link
Contributor

Update the naming in bb_proof_verification lib so that we guide users towards ZK by default (verify_honk_proof) and non-ZK is more opt-in (verify_honk_proof_non_zk)

@ledwards2225 ledwards2225 changed the base branch from next to merge-train/barretenberg November 7, 2025 15:23
@ledwards2225 ledwards2225 marked this pull request as ready for review November 7, 2025 15:23
@ledwards2225 ledwards2225 added the ci-full Run all master checks. label Nov 7, 2025
Copy link
Contributor

@federicobarbacovi federicobarbacovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@AztecBot
Copy link
Collaborator

AztecBot commented Nov 7, 2025

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033[38;2;188;109;208mFLAKED\033[0m (\033[38;2;250;217;121m8;;http://ci.aztec-labs.com/6c6bc7fc31177307�6c6bc7fc311773078;;�\033[0m): LOG_LEVEL=debug yarn-project/scripts/run_test.sh p2p/src/services/discv5/discv5_service.test.ts (66s) (code: 1) group:e2e-p2p-epoch-flakes (\033[38;2;188;109;208mledwards2225\033[0m: update naming in bb_proof_verification lib)

@ledwards2225 ledwards2225 merged commit 0fc8005 into merge-train/barretenberg Nov 7, 2025
24 checks passed
@ledwards2225 ledwards2225 deleted the lde/verification-lib-naming branch November 7, 2025 17:42
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2025
BEGIN_COMMIT_OVERRIDE
chore: remove more pg references and leftovers (#18260)
refactor: Migrate --update_inputs flag to --vk_policy option (#18237)
chore: stdlib byte_array and bool external audit fixes (#17838)
chore: update naming in bb_proof_verification lib (#18269)
chore: cycle group 13 (#18200)
chore: universal handling for coord constancy in cycle_group (#18253)
END_COMMIT_OVERRIDE
ludamad pushed a commit that referenced this pull request Dec 16, 2025
Update the naming in `bb_proof_verification` lib so that we guide users
towards ZK by default (`verify_honk_proof`) and non-ZK is more opt-in
(`verify_honk_proof_non_zk`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run all master checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants