chore: cycle group 13#18200
Merged
ledwards2225 merged 6 commits intomerge-train/barretenbergfrom Nov 7, 2025
Merged
Conversation
suyash67
approved these changes
Nov 7, 2025
barretenberg/cpp/src/barretenberg/stdlib/primitives/group/cycle_scalar.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/stdlib/primitives/group/cycle_scalar.cpp
Outdated
Show resolved
Hide resolved
| const field_t<Builder>& hi, | ||
| const size_t lo_bits, | ||
| const uint256_t& field_modulus); | ||
| void validate_split_in_field_unsafe(const field_t<Builder>& lo, |
Contributor
There was a problem hiding this comment.
nice, love the _unsafe usage here.
Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
BEGIN_COMMIT_OVERRIDE chore: remove more pg references and leftovers (#18260) refactor: Migrate --update_inputs flag to --vk_policy option (#18237) chore: stdlib byte_array and bool external audit fixes (#17838) chore: update naming in bb_proof_verification lib (#18269) chore: cycle group 13 (#18200) chore: universal handling for coord constancy in cycle_group (#18253) END_COMMIT_OVERRIDE
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Minor safety/docs updates to `cycle_scalar`, no logic changes - Add "unsafe" syntax to `validate_split_in_field_unsafe` to highlight that it only does what it claims when range constraints are applied on the lo/hi limbs (as is done when a cycle_scalar is used in batch_mul) - Make limbs `_lo`, `_hi` private members - Remove `skip_validation` bool from constructor; public constructor just always does it, option to not is private/internal use only --------- Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor safety/docs updates to
cycle_scalar, no logic changesvalidate_split_in_field_unsafeto highlight that it only does what it claims when range constraints are applied on the lo/hi limbs (as is done when a cycle_scalar is used in batch_mul)_lo,_hiprivate membersskip_validationbool from constructor; public constructor just always does it, option to not is private/internal use only