chore: remove more pg references and leftovers#18260
Merged
iakovenkos merged 5 commits intomerge-train/barretenbergfrom Nov 7, 2025
Merged
chore: remove more pg references and leftovers#18260iakovenkos merged 5 commits intomerge-train/barretenbergfrom
iakovenkos merged 5 commits intomerge-train/barretenbergfrom
Conversation
This commit completes the migration from ProtoGalaxy to Hypernova terminology throughout the codebase. Changes: - Updated code comments in prover_instance.hpp and verifier_instance.hpp to use generic folding terminology and reference Hypernova - Changed Noir circuit comments from "protogalaxy proof" to "folding proof" - Updated documentation in chonk.md to reference Hypernova paper (eprint.iacr.org/2023/573) instead of ProtoGalaxy - Added explicit BB_BENCH_NAME() calls to hypernova_prover.cpp and hypernova_verifier.cpp for better benchmarking - Updated bench_hardware_concurrency.sh to process HypernovaProver/Verifier metrics - Updated acir_format.cpp comments to use "HN" instead of "pg" - Added "hypernova" to cspell.json dictionary Note: Versioned documentation, CHANGELOGs, and security descriptions kept as-is for historical accuracy. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
johnathan79717
approved these changes
Nov 7, 2025
Contributor
johnathan79717
left a comment
johnathan79717
left a comment
There was a problem hiding this comment.
bench_hardware_concurrency changes and BB_BENCH_NAME(...) LGTM
iakovenkos
commented
Nov 7, 2025
| # - Upload the compressed results: aws s3 cp bb-chonk-inputs.tar.gz s3://aztec-ci-artifacts/protocol/bb-chonk-inputs-[hash(0:8)].tar.gz | ||
| # Note: In case of the "Test suite failed to run ... Unexpected token 'with' " error, need to run: docker pull aztecprotocol/build:3.0 | ||
| pinned_short_hash="7222b532" | ||
| pinned_short_hash="6322e510" |
Contributor
Author
There was a problem hiding this comment.
we are not hashing hardcoded zero target sum - hence vk updates
federicobarbacovi
approved these changes
Nov 7, 2025
Contributor
federicobarbacovi
left a comment
federicobarbacovi
left a comment
There was a problem hiding this comment.
LG, thanks for doing this!
| * the relation parameters, and the \f$\alpha_{i,j}\f$'s are the subrelation batching parameters. Then, \f$\phi\f$ is | ||
| * given by \f$\omega = ([p_1], \dots, [p_M], \theta_1, \dots, \theta_6, \alpha_{1,1}, \dots, \alpha_{n,r_n})\f$m where | ||
| * [p_i] denotes the commitment to the i-th prover polynomial. | ||
| * @details This is the committed version of a ProverInstance_. With the notation used in ProverInstance_, a prover |
Contributor
There was a problem hiding this comment.
If we remove the relevant part in ProverInstance, also this @details should go
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
BEGIN_COMMIT_OVERRIDE chore: remove more pg references and leftovers (#18260) refactor: Migrate --update_inputs flag to --vk_policy option (#18237) chore: stdlib byte_array and bool external audit fixes (#17838) chore: update naming in bb_proof_verification lib (#18269) chore: cycle group 13 (#18200) chore: universal handling for coord constancy in cycle_group (#18253) END_COMMIT_OVERRIDE
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Changes: - Updated code comments in prover_instance.hpp and verifier_instance.hpp to use generic folding terminology and reference Hypernova - Changed Noir circuit comments from "protogalaxy proof" to "folding proof" - Updated documentation in chonk.md to reference Hypernova paper (eprint.iacr.org/2023/573) instead of ProtoGalaxy - Added explicit BB_BENCH_NAME() calls to hypernova_prover.cpp and hypernova_verifier.cpp for better benchmarking - Updated bench_hardware_concurrency.sh to process HypernovaProver/Verifier metrics - Updated acir_format.cpp comments to use "HN" instead of "pg" - Added "hypernova" to cspell.json dictionary Note: Versioned documentation, CHANGELOGs, and security descriptions kept as-is for historical accuracy. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Please read [contributing guidelines](CONTRIBUTING.md) and remove this line. For audit-related pull requests, please use the [audit PR template](?expand=1&template=audit.md). --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Note: Versioned documentation, CHANGELOGs, and security descriptions kept as-is for historical accuracy.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.