Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Fixes a bug discovered by Consensys Dilligence in expression conversion
Cleanup and docs related to Ultra `ArithmeticRelation` - Name change: `UltraArithmeticRelation` --> `ArithmeticRelation` - Improved docs in relation - Update `UltraRelationConsistency::ArithmeticRelation` to make it easier to verify each "mode" of the relation - Comments about subtle scaling in builder methods that's necessitated by `ArithmeticRelation` details
Makes coordinates of biggroup private and adds both non mutating and mutating accessors (for now)
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
1 similar comment
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(ci/bb): enable BB_BENCH benchmarking in wasm (#17569)
fix: BB acir expression conversion issue (#17998)
chore: arithmetic relation cleanup (#17878)
chore: biggroup coordinates are private (#17923)
END_COMMIT_OVERRIDE