chore: biggroup coordinates are private#17923
Merged
ledwards2225 merged 11 commits intomerge-train/barretenbergfrom Oct 28, 2025
Merged
chore: biggroup coordinates are private#17923ledwards2225 merged 11 commits intomerge-train/barretenbergfrom
ledwards2225 merged 11 commits intomerge-train/barretenbergfrom
Conversation
suyash67
approved these changes
Oct 24, 2025
Contributor
suyash67
left a comment
suyash67
left a comment
There was a problem hiding this comment.
looks good! Thanks for adding the AUDITTODOs for mutable accesses, will take care of them in my audit.
ledwards2225
commented
Oct 28, 2025
| #endif | ||
| } | ||
|
|
||
| static void test_assert_coordinates_in_field() |
Contributor
Author
There was a problem hiding this comment.
Test for new method added to support ecdsa
ledwards2225
commented
Oct 28, 2025
| // Tags from members are merged | ||
| bool_ct pif = bool_ct(witness_ct(&builder, 0)); | ||
| // Create field elements with specific tags before constructing the biggroup element | ||
| affine_element input_c(element::random_element()); |
Contributor
Author
There was a problem hiding this comment.
just rearranging this test to not modify coordinates of a biggroup element directly. Instead modify prio to construction
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Makes coordinates of biggroup private and adds both non mutating and mutating accessors (for now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes coordinates of biggroup private and adds both non mutating and mutating accessors (for now)