chore: arithmetic relation cleanup#17878
Merged
ledwards2225 merged 5 commits intomerge-train/barretenbergfrom Oct 28, 2025
Merged
chore: arithmetic relation cleanup#17878ledwards2225 merged 5 commits intomerge-train/barretenbergfrom
ledwards2225 merged 5 commits intomerge-train/barretenbergfrom
Conversation
notnotraju
reviewed
Oct 27, 2025
| this->assert_valid_variables({ in.a, in.b, in.c, in.d }); | ||
| blocks.arithmetic.populate_wires(in.a, in.b, in.c, in.d); | ||
| blocks.arithmetic.q_m().emplace_back(include_next_gate_w_4 ? in.mul_scaling * FF(2) : in.mul_scaling); | ||
| // If include_next_gate_w_4 is true then we set q_arith = 2. In this case, the linear term in the ArithmeticRelation |
notnotraju
approved these changes
Oct 27, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Cleanup and docs related to Ultra `ArithmeticRelation` - Name change: `UltraArithmeticRelation` --> `ArithmeticRelation` - Improved docs in relation - Update `UltraRelationConsistency::ArithmeticRelation` to make it easier to verify each "mode" of the relation - Comments about subtle scaling in builder methods that's necessitated by `ArithmeticRelation` details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup and docs related to Ultra
ArithmeticRelationUltraArithmeticRelation-->ArithmeticRelationUltraRelationConsistency::ArithmeticRelationto make it easier to verify each "mode" of the relationArithmeticRelationdetails