Open
Conversation
This was referenced Sep 12, 2025
Merged
Contributor
Author
This was referenced Sep 12, 2025
LHerskind
commented
Sep 12, 2025
| assertEq(rollup.getActiveAttesterCount(), VALIDATOR_COUNT, "All validators should remain active after small slash"); | ||
| } | ||
|
|
||
| function test_SlashingLargeAmount_smallLocalEjectionThreshold() public { |
Contributor
Author
There was a problem hiding this comment.
This one is essentially the previous test. The diff in them is just whether we altered the local ejection threshold.
just-mitch
reviewed
Sep 12, 2025
| slashAmountSmall: BigInt(10e18), | ||
| slashAmountMedium: BigInt(20e18), | ||
| slashAmountLarge: BigInt(50e18), | ||
| activationThreshold: 200_000n * 10n ** 18n, |
Collaborator
There was a problem hiding this comment.
I think this will cause staging public to deploy with different addresses.
Collaborator
There was a problem hiding this comment.
Disregard- we'll need to just make the deploy scripts smarter
Base automatically changed from
lh/tmnt-261-coin-issuer-configuration
to
next
September 14, 2025 22:04
LHerskind
force-pushed
the
lh/tmnt-260-gse-configuration
branch
from
1aa4cbe to
9f22818
Compare
LHerskind
changed the title
LHerskind
force-pushed
the
lh/tmnt-260-gse-configuration
branch
from
9f22818 to
2d76ae9
Compare
LHerskind
force-pushed
the
lh/tmnt-260-gse-configuration
branch
from
2d76ae9 to
289d803
Compare
just-mitch
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.