Merged
Conversation
Contributor
Author
aminsammara
reviewed
Sep 5, 2025
yarn-project/ethereum/src/config.ts
Outdated
| aztecProofSubmissionEpochs: 1, // you have a full epoch to submit a proof after the epoch to prove ends | ||
| activationThreshold: BigInt(100e18), | ||
| ejectionThreshold: BigInt(50e18), | ||
| localEjectionThreshold: BigInt(0), // No effective local threshold when value ends below ejectionThreshold |
Contributor
There was a problem hiding this comment.
Should we set a more realistic default value? We expect inactivity slash to be 1% and we want 3 slashes and you're out. So 97%?
Contributor
Author
There was a problem hiding this comment.
Sure, can update it.
LHerskind
force-pushed
the
lh/tmnt-265-add-stricter-ejection_threshold-at-the-rollup-level
branch
from
a0808c4 to
7d53665
Compare
LHerskind
force-pushed
the
lh/tmnt-207-proposer-griefing-dos
branch
from
87a808d to
e9f577f
Compare
This was referenced Sep 8, 2025
LHerskind
force-pushed
the
lh/tmnt-265-add-stricter-ejection_threshold-at-the-rollup-level
branch
from
7d53665 to
56b451e
Compare
LHerskind
force-pushed
the
lh/tmnt-207-proposer-griefing-dos
branch
from
e9f577f to
2f71e44
Compare
just-mitch
reviewed
Sep 8, 2025
| beforeEach(async () => { | ||
| t = await P2PNetworkTest.create({ | ||
| testName: 'e2e_p2p_gerousia', | ||
| testName: 'e2e_p2p_upgrade_governance_proposer', |
just-mitch
reviewed
Sep 8, 2025
yarn-project/ethereum/src/config.ts
Outdated
| } | ||
| }; | ||
|
|
||
| const TestnetGSEConfiguration = { |
Collaborator
There was a problem hiding this comment.
Oh yikes did not know these got lifted to environment variables 😬
Contributor
Author
There was a problem hiding this comment.
Seemed like they already were. But multiple places passed values were not properly used (that was how the upgrade_governance_proposer.test.ts ended up with slight updates
just-mitch
approved these changes
Sep 8, 2025
LHerskind
force-pushed
the
lh/tmnt-265-add-stricter-ejection_threshold-at-the-rollup-level
branch
from
56b451e to
f85a17f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
LHerskind
deleted the
lh/tmnt-265-add-stricter-ejection_threshold-at-the-rollup-level
branch
This was referenced Sep 10, 2025
Merged
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "local" ejection threshold that allows the rollup to enforce a stricter limit for when people are exited entirely.
This allow us to have relaxed limits on the GSE, while giving the rollup flexibility.