chore: set config params for staging-ignition and testnet by just-mitch · Pull Request #16976 · AztecProtocol/aztec-packages

just-mitch · 2025-09-11T21:01:39Z

See https://linear.app/aztec-labs/issue/TMNT-258/configuration

alexghr

Looks great but the large numbers need to either be strings or defined using bigint powers (e.g. 10n ** 18n)

alexghr · 2025-09-11T22:00:48Z

yarn-project/cli/src/config/chain_l2_config.ts

+  slashAmountSmall: BigInt(2_000e18),
+  slashAmountMedium: BigInt(10_000e18),
+  slashAmountLarge: BigInt(50_000e18),


This is not safe. This would convert 2000e18 from a number to a bigint but 2000e18 is greater than Number.MAX_SAFE_INTEGER so it'll overflow before it is converted to bigint

alexghr · 2025-09-11T22:01:14Z

yarn-project/cli/src/config/chain_l2_config.ts

+  localEjectionThreshold: BigInt(196_000e18),
+
+  ejectionThreshold: BigInt(100_000e18),
+  activationThreshold: BigInt(200_000e18),


aminsammara · 2025-09-12T07:15:36Z

yarn-project/cli/src/config/chain_l2_config.ts

+
+  slashingRoundSizeInEpochs: 4,
+  slashingLifetimeInRounds: 40,
+  slashingExecutionDelayInRounds: 20,


Suggested change

slashingExecutionDelayInRounds: 20,

slashingExecutionDelayInRounds: 28,

We talked about having a 3 day slashing execution delay and a 5 day exit delay.

aminsammara · 2025-09-12T07:18:16Z

yarn-project/cli/src/config/chain_l2_config.ts

+  slashingExecutionDelayInRounds: 20,
+  slashAmountSmall: BigInt(2_000e18),
+  slashAmountMedium: BigInt(10_000e18),
+  slashAmountLarge: BigInt(50_000e18),


slashAmountLarge: BigInt(50_000e18),

I think this is fine for Ignition where there is no txs, but for Alpha this slashAmountLarge would need to be close to 100% of the stake.

aminsammara · 2025-09-12T07:29:50Z

yarn-project/cli/src/config/chain_l2_config.ts

+  slashMinPenaltyPercentage: 0.5,
+  slashMaxPenaltyPercentage: 2.0,
+  slashInactivityTargetPercentage: 0.7,
+  slashInactivityConsecutiveEpochThreshold: 1,


Can we set this to two to test it out?

aminsammara · 2025-09-12T07:35:00Z

yarn-project/cli/src/config/chain_l2_config.ts

+  slashUnknownPenalty: BigInt(2_000e18),
+  slashBroadcastedInvalidBlockPenalty: BigInt(10_000e18),
+  slashMaxPayloadSize: 50,
+  slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis


Suggested change

slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis

slashGracePeriodL2Slots: 32 * 4, // One round from genesis

aminsammara · 2025-09-12T07:36:08Z

yarn-project/cli/src/config/chain_l2_config.ts

+  slashBroadcastedInvalidBlockPenalty: BigInt(10_000e18),
+  slashMaxPayloadSize: 50,
+  slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis
+  slashOffenseExpirationRounds: 8,


Question: is there any point setting this to far above the slashingOffsetInRounds?

Should take input from @spalladino here.

Just debugging. Any offenses still in the store can be queried via the node admin API.

aminsammara · 2025-09-12T07:36:34Z

yarn-project/ethereum/src/config.ts

  proposeConfig: {
-    lockDelay: 60n * 60n * 24n,
-    lockAmount: DefaultL1ContractsConfig.activationThreshold * 100n,
+    lockDelay: 60n * 24n * 60n * 60n, // 60 days


For testnet? Why?

yarn-project/ethereum/src/config.ts

LHerskind · 2025-09-16T14:29:14Z

yarn-project/ethereum/src/config.ts

@@ -125,31 +125,32 @@ const StagingPublicGovernanceConfiguration = {

 const TestnetGovernanceConfiguration = {


I think the values are mostly sane, but would have preferred seeing it not explode in tests first (when trying to update some of these in the #16988 I ran into plenty things)

LHerskind · 2025-09-16T14:30:37Z

yarn-project/ethereum/src/config.ts

-  slashAmountLarge: BigInt(50e18),
+  activationThreshold: 100n * 10n ** 18n,
+  ejectionThreshold: 50n * 10n ** 18n,
+  localEjectionThreshold: 98n * 10n ** 18n,


None of these values (except slashAmountLarge) matches what we have in the issue TMNT-263: Rollup Configuration) so don't think they are running any tests with the new values at all. (I had issue with that).

They were getting set explicitly over in the chain l2 config, but I will update here as well.

If we change the defaults much here you will see an insane amount of tests failing because many of them are using hard coded values 😬

yarn-project/cli/src/config/chain_l2_config.ts

yarn-project/ethereum/src/config.ts

LHerskind · 2025-09-17T08:19:46Z

yarn-project/ethereum/src/config.ts

  a: 1000,
-  k: 1000000,
-  minimum: 100000,
+  k: 100000,


The existing value was the correct here. It has now been invalidated. All of the reward configs really should just be the same so there is only one and that one would be the TestnetRewardBoostConfig. I will update that.

LHerskind · 2025-09-17T09:16:22Z

I pushed an update to the cofngis here, and will be running it on a solidity branch to ensure that the config make it behaves correctly.

LHerskind · 2025-09-17T09:16:25Z

chore: set config params for staging-ignition and testnet #16976 👈 (View in Graphite)
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

LHerskind · 2025-09-17T09:56:53Z

I pushed an update to the cofngis here, and will be running it on a solidity branch to ensure that the config make it behaves correctly.

There are some failing tests but they are all related to the configurations changing and some slashing tests, e.g., empire vs. tally and previously having run with 0 delay.

LHerskind

I have updated the reward booster configuration such that there will be only one. It does not make much sense to me that there are actually multiple different ones between networks.

LHerskind · 2025-09-17T10:10:45Z

I pushed an update to the cofngis here, and will be running it on a solidity branch to ensure that the config make it behaves correctly.

There are some failing tests but they are all related to the configurations changing and some slashing tests, e.g., empire vs. tally and previously having run with 0 delay.

Will be adding fixes and moving this more into the solidity tests as well in #16988

just-mitch mentioned this pull request Sep 11, 2025

chore: ignition config #16953

Closed

just-mitch added the hotfix A PR/issue that needs to be cherrypicked back to the RC label Sep 11, 2025

alexghr reviewed Sep 11, 2025

View reviewed changes

aminsammara reviewed Sep 12, 2025

View reviewed changes

just-mitch force-pushed the mitch/tmnt-258-configuration branch 3 times, most recently from fa8a445 to 6c3986b Compare September 16, 2025 11:01

LHerskind reviewed Sep 16, 2025

View reviewed changes

just-mitch force-pushed the mitch/tmnt-258-configuration branch 3 times, most recently from cd84e6e to 4799590 Compare September 16, 2025 23:06

LHerskind reviewed Sep 17, 2025

View reviewed changes

chore: ignition parameters

f2bee27

LHerskind force-pushed the mitch/tmnt-258-configuration branch from 4799590 to f2bee27 Compare September 17, 2025 09:16

LHerskind approved these changes Sep 17, 2025

View reviewed changes

PhilWindle added this pull request to the merge queue Sep 17, 2025

Merged via the queue into next with commit 3bf6083 Sep 17, 2025
15 checks passed

PhilWindle deleted the mitch/tmnt-258-configuration branch September 17, 2025 11:06

ludamad pushed a commit that referenced this pull request Dec 16, 2025

chore: set config params for staging-ignition and testnet (#16976)

b70fba4

	slashingExecutionDelayInRounds: 20,
	slashingExecutionDelayInRounds: 28,

	slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis
	slashGracePeriodL2Slots: 32 * 4, // One round from genesis

		@@ -125,31 +125,32 @@ const StagingPublicGovernanceConfiguration = {

		const TestnetGovernanceConfiguration = {

Conversation

just-mitch commented Sep 11, 2025

Uh oh!

alexghr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LHerskind Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LHerskind commented Sep 17, 2025

Uh oh!

LHerskind commented Sep 17, 2025

Uh oh!

LHerskind commented Sep 17, 2025

Uh oh!

LHerskind left a comment

Choose a reason for hiding this comment

Uh oh!

LHerskind commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LHerskind Sep 17, 2025 •

edited

Loading