feat!: verifying civc in tx base#16713
Merged
LeilaWang merged 1 commit intomerge-train/barretenbergfrom Sep 9, 2025
Merged
Conversation
LeilaWang
requested review from
LeilaWang,
charlielye,
dbanks12,
fcarreiro and
sirasistant
as code owners
LeilaWang
removed request for
LeilaWang,
charlielye,
dbanks12,
fcarreiro and
sirasistant
LeilaWang
changed the title
LeilaWang
force-pushed
the
lw/removing_tube
branch
from
259d09b to
4962c66
Compare
alexghr
approved these changes
Sep 8, 2025
Contributor
alexghr
left a comment
alexghr
left a comment
There was a problem hiding this comment.
The typescript changes look good to me! I'd be interested to see how proving performance changes because the tube proof was run in parallel with the AVM proof. 👍
Does the tx proof size change at all?
ledwards2225
commented
Sep 8, 2025
| } else if (flags.verifier_type == "standalone") { | ||
| write_standalone_vk(bytecode_path, output_path); | ||
| write_standalone_vk(bytecode, output_path); | ||
| } else if (flags.verifier_type == "standalone_tail") { |
Contributor
Author
There was a problem hiding this comment.
nit but this should probably be standalone_hiding
Collaborator
|
Note we may want to target merge-train/barretenberg with this as I have done some changes relevant here with the write_vk changes. Shouldnt have issues tho |
LeilaWang
force-pushed
the
lw/removing_tube
branch
2 times, most recently
from
de0db85 to
00f4577
Compare
LeilaWang
force-pushed
the
lw/removing_tube
branch
from
00f4577 to
ba9b9af
Compare
Contributor
|
@alexghr The public base added more than 10s when verifying civc in it. So I created a noir circuit for public tube so that we can still prove them in parallel. The private base is still verifying the civc, because the overall time is less: But let me know if we prefer to prove them separately, I can add a private tube circuit. The tx size is smaller now because the size of |
This was referenced Sep 10, 2025
This was referenced Sep 16, 2025
federicobarbacovi
added a commit
that referenced
this pull request
Sep 19, 2025
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
fcarreiro
pushed a commit
that referenced
this pull request
Sep 22, 2025
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Remove the tube and verify `hiding_kernel_to_rollup` directly in private tx base rollup. Create a public tube circuit in noir that verifies `hiding_kernel_to_public`. The public tube proof is verified in the public tx base rollup. Remove the fake tube vks and use the pre-generated vks in `noir-protocol-circuit` for verification. All circuits now ensure that the vks are in the vk tree. Change `ClientIvcProof.ts` to contain proof fields instead of buffer. The proof fields will be used by the orchestrator to construct the private inputs to be recursively verified in private base or public tube. Co-authored-by: Leila Wang <leizciw@gmail.com>
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Remove the tube and verify `hiding_kernel_to_rollup` directly in private tx base rollup. Create a public tube circuit in noir that verifies `hiding_kernel_to_public`. The public tube proof is verified in the public tx base rollup. Remove the fake tube vks and use the pre-generated vks in `noir-protocol-circuit` for verification. All circuits now ensure that the vks are in the vk tree. Change `ClientIvcProof.ts` to contain proof fields instead of buffer. The proof fields will be used by the orchestrator to construct the private inputs to be recursively verified in private base or public tube. Co-authored-by: Leila Wang <leizciw@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the tube and verify
hiding_kernel_to_rollupdirectly in private tx base rollup.Create a public tube circuit in noir that verifies
hiding_kernel_to_public. The public tube proof is verified in the public tx base rollup.Remove the fake tube vks and use the pre-generated vks in
noir-protocol-circuitfor verification. All circuits now ensure that the vks are in the vk tree.Change
ClientIvcProof.tsto contain proof fields instead of buffer. The proof fields will be used by the orchestrator to construct the private inputs to be recursively verified in private base or public tube.