chore: Tube-related clean up#17064
chore: Tube-related clean up#17064federicobarbacovi merged 6 commits intomerge-train/barretenbergfrom
Conversation
| info("Recursive Verifier: finalized num gates = ", builder.num_gates); | ||
| } | ||
|
|
||
| TEST_F(ClientIVCRecursionTests, ClientTubeBase) |
There was a problem hiding this comment.
This test is subsided by this test in civc_recursion_constraints (in that test we prove and verify a circuit containing a CIVC recursive verifier, i.e., a tube circuit) and by ultra recursive verifier tests, which test that an ultra recursive verifier can be proven and verified.
Together, these tests ensure that a CIVC recursive verifier can be proven and that its proof can be recursively verified, which are the two cases of interest:
- CIVC recursive verifier proven = Private Base Rollup
- CIVC recursive verifier proven and recursively verified = Public Base Rollup
| } | ||
|
|
||
| // Ensure that the Client IVC Recursive Verifier Circuit does not depend on the Client IVC input | ||
| TEST_F(ClientIVCRecursionTests, TubeVKIndependentOfInputCircuits) |
There was a problem hiding this comment.
This test is a duplicate of this test in civc_recursion_constraints
federicobarbacovi
force-pushed
the
fb/tube_cleanup
branch
2 times, most recently
from
6072dda to
221cd9e
Compare
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
Nice! Thanks for doing this
| # - Upload the compressed results: aws s3 cp bb-civc-inputs.tar.gz s3://aztec-ci-artifacts/protocol/bb-civc-inputs-[hash(0:8)].tar.gz | ||
| # Note: In case of the "Test suite failed to run ... Unexpected token 'with' " error, need to run: docker pull aztecprotocol/build:3.0 | ||
| pinned_short_hash="58c67fe7" | ||
| pinned_short_hash="a659d9fa" |
There was a problem hiding this comment.
I assume this is just an outdated conflict?
There was a problem hiding this comment.
I think it was a conflict that came about after CI run successfully on this PR. I rebased and now there are no merge conflicts
federicobarbacovi
force-pushed
the
fb/tube_cleanup
branch
from
7298243 to
f128754
Compare
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713) Closes AztecProtocol/barretenberg#1523
2 participants
Clean up of tube-related files and functions following the move of the tube to Noir (see #16400 and #16713)
Closes AztecProtocol/barretenberg#1523