Conversation
At last! Add randomness to the UltraOp version of the op queue and ensure proper handling in Translator. This makes the Translator and Merge proof actually zero knowledge. The caveat is, because Translator is zero-knowledge by default, we have to ensure these changes don't affect the AVM recursive verifier. There, we only ever accumulate one circuit so we don't want to do an artificial append merge with offset. As such, I opted for translator not expecting to process random ops at the end of the op queue when the op queue is derived from the goblin recursive verifier circuit. We however add the three random ops at the beginning of the op queue by default as otherwise we'd have to alter Translator relations based on whether Goblin is used in AVM or CIVC. Closes AztecProtocol/barretenberg#1360
AztecBot
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Remove the tube and verify `hiding_kernel_to_rollup` directly in private tx base rollup. Create a public tube circuit in noir that verifies `hiding_kernel_to_public`. The public tube proof is verified in the public tx base rollup. Remove the fake tube vks and use the pre-generated vks in `noir-protocol-circuit` for verification. All circuits now ensure that the vks are in the vk tree. Change `ClientIvcProof.ts` to contain proof fields instead of buffer. The proof fields will be used by the orchestrator to construct the private inputs to be recursively verified in private base or public tube. Co-authored-by: Leila Wang <leizciw@gmail.com>
LeilaWang
requested review from
LeilaWang,
charlielye,
dbanks12 and
sirasistant
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: ZK CIVC (#16687)
feat!: verifying civc in tx base (#16713)
END_COMMIT_OVERRIDE