feat: completing partial notes in private by benesjan · Pull Request #14533 · AztecProtocol/aztec-packages

benesjan · 2025-05-26T11:38:50Z

Implements partial note completion in private. This PR is quite big but I decided to just keep it like that because:

we currently don't have a way to unit test oracles,
testing partial notes flows in TXE test doesn't really work..

This prevented me from implementing the oracles, the partial note completion and Orderbook changes in 3 PRs as I needed them in one to verify it works.

Update

~~Mr. Nico said this is too ugly (😭) and that I should do #10273 first~~

The above is addressed now.

benesjan · 2025-05-26T11:39:11Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

yarn-project/stdlib/src/logs/log_with_tx_data.ts

benesjan · 2025-05-27T08:51:02Z

noir-projects/aztec-nr/uint-note/src/uint_note.nr

+        context.emit_private_log(
+            self.compute_note_completion_log_padded_for_private_log(value),
+            NOTE_COMPLETION_LOG_LENGTH,
+        );


I find the emit_private_log API on context quite weird as we kinda pass a BoundedVec here but not really. Shall we just change it to use BoundedVec? Then I would not have to do the ugly manual padding here.

Created #14709

noir-projects/aztec-nr/aztec/src/oracle/message_discovery.nr

benesjan · 2025-05-27T09:40:27Z

noir-projects/aztec-nr/uint-note/src/uint_note.nr


-    fn compute_note_completion_log(self, value: u128) -> [Field; 2] {
+    /// Completes the partial note, creating a new note that can be used like any other UintNote.
+    pub fn complete_from_private(self, value: u128, context: &mut PrivateContext) {


I don't perform to zero value check here like in public since it looks like we have the info of real private log length and hence the 0 value should not get trimmed. Can write a test for this if the reviewer is not sure if it's correct.

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr

Public logs are prefixed with contract address and we were returning it like that from `get_public_log_by_tag`. This was annoying as private logs are not prefixed with it forcing us to treat them differently in #14533. In this PR I drop the contract address and the tag from the return value of the oracle as it's not needed in `Aztec.nr`. Decided to drop the tag in the oracle response as opposed to dropping that in `Aztec.nr` as we directly map there `PublicLogWithTxData` from TS to Noir so dropping that in Noir would be weird. Fixes #10273 --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr

noir-projects/aztec-nr/aztec/src/messages/discovery/partial_notes.nr

nventuro · 2025-06-03T02:54:20Z

noir-projects/aztec-nr/uint-note/src/uint_note.nr

+        context.emit_private_log(
+            self.compute_note_completion_log_padded_for_private_log(value),
+            NOTE_COMPLETION_LOG_LENGTH,
+        );


Created #14709

noir-projects/aztec-nr/aztec/src/oracle/message_processing.nr

noir-projects/noir-contracts/contracts/app/orderbook_contract/src/main.nr

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr

…f public and private log lengths

benesjan mentioned this pull request May 26, 2025

refactor!: helpers for AztecNode::getLogsByTags and related oracle change #14459

Merged

benesjan mentioned this pull request May 26, 2025

feat: simple Orderbook DEX #14464

Merged

benesjan changed the title ~~feat:completing partial notes in private~~ feat: completing partial notes in private May 26, 2025

benesjan commented May 27, 2025

View reviewed changes

yarn-project/stdlib/src/logs/log_with_tx_data.ts Outdated Show resolved Hide resolved

benesjan commented May 27, 2025

View reviewed changes

noir-projects/aztec-nr/aztec/src/oracle/message_discovery.nr Outdated Show resolved Hide resolved

benesjan commented May 27, 2025

View reviewed changes

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr Outdated Show resolved Hide resolved

benesjan mentioned this pull request May 27, 2025

Write AMM TXE tests #10289

Closed

benesjan marked this pull request as ready for review May 27, 2025 10:16

benesjan requested a review from nventuro May 27, 2025 10:51

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 112559e to fbdfabe Compare May 27, 2025 13:39

benesjan force-pushed the 05-22-feat_simple_orderbook_dex branch from 0610d9f to 6c8ce5d Compare May 27, 2025 13:39

benesjan marked this pull request as draft May 27, 2025 13:53

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch 2 times, most recently from c254b4a to 9d0b171 Compare May 27, 2025 14:27

benesjan force-pushed the 05-22-feat_simple_orderbook_dex branch 2 times, most recently from 989ed05 to 0f7d2b1 Compare May 27, 2025 14:37

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch 2 times, most recently from 2a63440 to d752a3d Compare May 27, 2025 14:47

benesjan force-pushed the 05-22-feat_simple_orderbook_dex branch from 0f7d2b1 to 3b5017b Compare May 27, 2025 14:47

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from d752a3d to 4bceb75 Compare May 28, 2025 06:51

benesjan force-pushed the 05-22-feat_simple_orderbook_dex branch from 3b5017b to 65f6141 Compare May 28, 2025 06:51

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 4bceb75 to 20f0948 Compare May 28, 2025 07:00

Base automatically changed from 05-22-feat_simple_orderbook_dex to next May 28, 2025 08:05

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 20f0948 to 6dc9bba Compare May 28, 2025 08:14

benesjan changed the title ~~feat: completing partial notes in private~~ [NO MERGE] feat: completing partial notes in private May 28, 2025

benesjan mentioned this pull request May 28, 2025

refactor: saner public logs oracle #14569

Merged

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 6dc9bba to a71342f Compare May 28, 2025 14:21

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 4df48b0 to 5ca9a2a Compare May 28, 2025 17:10

benesjan changed the title ~~[NO MERGE] feat: completing partial notes in private~~ feat: completing partial notes in private May 28, 2025

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch 2 times, most recently from 76050a2 to ccdc5d5 Compare May 29, 2025 10:48

benesjan marked this pull request as ready for review May 29, 2025 10:49

benesjan marked this pull request as draft May 29, 2025 10:56

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 0f55a96 to 982b0d2 Compare May 29, 2025 11:38

benesjan commented May 29, 2025

View reviewed changes

noir-projects/noir-contracts/contracts/app/token_contract/src/main.nr Show resolved Hide resolved

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 982b0d2 to 4d1a1c6 Compare May 29, 2025 12:08

benesjan marked this pull request as ready for review May 29, 2025 12:09

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 0f856d3 to 3873ba1 Compare June 2, 2025 07:53

nventuro mentioned this pull request Jun 3, 2025

Batch partial note completion requests #14710

Closed

nventuro approved these changes Jun 3, 2025

View reviewed changes

benesjan marked this pull request as draft June 3, 2025 06:28

benesjan added 4 commits June 3, 2025 06:28

WIP

ecba6d2

fmt

5e6a696

more consistent naming

f518f92

nicer diff

f0e1778

benesjan force-pushed the 05-26-feat_completing_partial_notes_in_private branch from 3b43f78 to f0e1778 Compare June 3, 2025 06:29

benesjan added 2 commits June 3, 2025 06:40

refactor: update MAX_PARTIAL_NOTE_COMPLETION_LOG_LEN to use minimum o…

a4e35ba

…f public and private log lengths

nuked comment

985997b

benesjan marked this pull request as ready for review June 3, 2025 06:46

benesjan enabled auto-merge June 3, 2025 06:48

benesjan added this pull request to the merge queue Jun 3, 2025

Merged via the queue into next with commit 2078cf0 Jun 3, 2025
9 checks passed

benesjan deleted the 05-26-feat_completing_partial_notes_in_private branch June 3, 2025 07:33

AztecBot mentioned this pull request Jun 3, 2025

chore(next): release 0.88.0 #14495

Closed

jilio mentioned this pull request Mar 13, 2026

feat: commitment-based payments with custom token contract fork jilio/aztec-x402#6

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: completing partial notes in private#14533

feat: completing partial notes in private#14533
benesjan merged 6 commits intonextfrom
05-26-feat_completing_partial_notes_in_private

benesjan commented May 26, 2025 •

edited

Loading

Uh oh!

benesjan commented May 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

benesjan May 27, 2025

Uh oh!

nventuro Jun 3, 2025

Uh oh!

Uh oh!

benesjan May 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nventuro Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

benesjan commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update

Uh oh!

benesjan commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

benesjan May 27, 2025

Choose a reason for hiding this comment

Uh oh!

nventuro Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

benesjan May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nventuro Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benesjan commented May 26, 2025 •

edited

Loading

benesjan commented May 26, 2025 •

edited

Loading