Merged
Conversation
benesjan
force-pushed
the
05-28-refactor_saner_public_logs
branch
from
1afeac3 to
fd5bd52
Compare
benesjan
changed the title
benesjan
commented
May 28, 2025
nventuro
approved these changes
May 28, 2025
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
This might be my favourite PR in the month.
Note that you did not remove the tag from PendingTaggedLog, from the fetchTaggedLogs oracle. Do you think we should, for consistency?
noir-projects/aztec-nr/aztec/src/messages/discovery/partial_notes.nr
Outdated
Show resolved
Hide resolved
…tes.nr Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
…s.nr Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
…s.nr Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
benesjan
force-pushed
the
05-28-refactor_saner_public_logs
branch
from
4465d2d to
519b6d6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public logs are prefixed with contract address and we were returning it like that from
get_public_log_by_tag. This was annoying as private logs are not prefixed with it forcing us to treat them differently in #14533. In this PR I drop the contract address and the tag from the return value of the oracle as it's not needed inAztec.nr.Decided to drop the tag in the oracle response as opposed to dropping that in
Aztec.nras we directly map therePublicLogWithTxDatafrom TS to Noir so dropping that in Noir would be weird.Fixes #10273