Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
getLogsByTags to public and private versions
benesjan
commented
May 22, 2025
benesjan
commented
May 22, 2025
benesjan
changed the title
getLogsByTags to public and private versionsAztecNode::getLogsByTags to public and private versions
nventuro
reviewed
May 23, 2025
yarn-project/pxe/src/pxe_oracle_interface/pxe_oracle_interface.ts
Outdated
Show resolved
Hide resolved
benesjan
force-pushed
the
05-22-refactor_separating_getlogsbytags_to_public_and_private_versions
branch
from
1faf365 to
2d318b3
Compare
benesjan
changed the title
AztecNode::getLogsByTags to public and private versionsAztecNode::getLogsByTags to public and private versions
benesjan
changed the title
AztecNode::getLogsByTags to public and private versionsAztecNode::getLogsByTags and related oracle change
Contributor
Docs PreviewYou can check your preview here. |
This was referenced May 26, 2025
nventuro
approved these changes
May 27, 2025
yarn-project/pxe/src/pxe_oracle_interface/pxe_oracle_interface.ts
Outdated
Show resolved
Hide resolved
benesjan
force-pushed
the
graphite-base/14459
branch
from
8481950 to
aae5ab0
Compare
benesjan
force-pushed
the
05-22-refactor_separating_getlogsbytags_to_public_and_private_versions
branch
from
aff6028 to
0e0996d
Compare
benesjan
force-pushed
the
05-22-refactor_separating_getlogsbytags_to_public_and_private_versions
branch
from
0e0996d to
d729134
Compare
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
benesjan
force-pushed
the
05-22-refactor_separating_getlogsbytags_to_public_and_private_versions
branch
from
d729134 to
7ab9935
Compare
benesjan
force-pushed
the
graphite-base/14459
branch
from
3ca26cd to
3a84f53
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 27, 2025
…change (#14459) Fixes #11639 Nowhere in our codebase we wanted to receive both public and private logs and for this reason I separated the 2 APIs. This was especially problematic in Noir (getLogByTag function) as public and private logs have different lengths. For the public logs we also wanted filtering by contract address so I modified the API to do that. --------- Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
deleted the
05-22-refactor_separating_getlogsbytags_to_public_and_private_versions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11639
Nowhere in our codebase we wanted to receive both public and private logs and for this reason I separated the 2 APIs. This was especially problematic in Noir (getLogByTag function) as public and private logs have different lengths.
For the public logs we also wanted filtering by contract address so I modified the API to do that.