chore: Protocol breaking changes must now go to next branch. by charlielye · Pull Request #14423 · AztecProtocol/aztec-packages

charlielye · 2025-05-20T18:33:07Z

Set new TARGET_BRANCH env var.
Add @LHerskind scream and shout test to test_cmds if target branch is master.
We trigger the release please workflow on a merge to the next branch as well as master.
We update the release please config to tell it what to do on next.
master will no longer be pre-release
next will be pre-release
benchmarks can be found in bench/master and bench/next.

LHerskind · 2025-05-21T15:15:45Z

l1-contracts/bootstrap.sh

@@ -56,6 +56,9 @@ function test_cmds {
  echo "$hash cd l1-contracts && solhint --config ./.solhint.json \"src/**/*.sol\""
  echo "$hash cd l1-contracts && forge fmt --check"
  echo "$hash cd l1-contracts && forge test --no-match-contract UniswapPortalTest"


The --no-match-contract UniswapPortalTest should not be here when the cahnge was made in foundry.toml.

The change in the toml is applied to forge test calls such that we skip uniswap and the scream and shout test explicitly. This is visible from https://github.com/AztecProtocol/aztec-packages/pull/14414/files

Suggested change

echo "$hash cd l1-contracts && forge test --no-match-contract UniswapPortalTest"

echo "$hash cd l1-contracts && forge test"

Currently you would end up running the scream and shout every time here.

LHerskind · 2025-05-21T15:16:42Z

l1-contracts/test/shouting.t.sol

+    bytes memory creationCode = type(HonkVerifier).creationCode;
+    bytes32 codeHash = keccak256(creationCode);
+
+    assertEq(codeHash, 0x892b4a5c70e2e665b147db8ae02a0410ae400adefd02d85feb56847593d4b9dd, ERR_STRING);


Needs to run the formatter. http://ci.aztec-labs.com/48f8b45a858465f3

fcarreiro · 2025-05-21T17:48:48Z

Are the benchmarks now expected to follow next?

charlielye · 2025-05-21T18:00:43Z

Are the benchmarks now expected to follow next?

Good question and thanks for ruining my evening :)
I wanted two of the same, one at bench/master the other at bench/next.
Will look into it.

…uts.

…ec-packages into cl/release_please_next

@LHerskind

* Set new TARGET_BRANCH env var. * Add @LHerskind scream and shout test to `test_cmds` if target branch is master. * We trigger the release please workflow on a merge to the `next` branch as well as `master`. * We update the release please config to tell it what to do on `next`. * `master` will no longer be pre-release * `next` will be pre-release * benchmarks can be found in `bench/master` and `bench/next`.

@LHerskind

* Set new TARGET_BRANCH env var. * Add @LHerskind scream and shout test to `test_cmds` if target branch is master. * We trigger the release please workflow on a merge to the `next` branch as well as `master`. * We update the release please config to tell it what to do on `next`. * `master` will no longer be pre-release * `next` will be pre-release * benchmarks can be found in `bench/master` and `bench/next`.

🤖 I have created a new Aztec Packages release --- ## [0.87.3](v0.87.2...v0.87.3) (2025-05-28) ### ⚠ BREAKING CHANGES * app benches and unified PXE creation ([#14504](#14504)) * Removes normalize() calls on pairing points ([#14285](#14285)) ### Features * Adds StarknetZK WASM bindings to bb.js ([#14372](#14372)) ([224b219](224b219)) * app benches and unified PXE creation ([#14504](#14504)) ([aae5ab0](aae5ab0)) * **bb:** memory tracking for microbenchmarks ([#14445](#14445)) ([fae2961](fae2961)) * enable provers to run in node chart ([#14405](#14405)) ([94edd35](94edd35)) * measure oracles ([#14552](#14552)) ([9cc6b54](9cc6b54)) * Removes normalize() calls on pairing points ([#14285](#14285)) ([942b948](942b948)) * unbundled bb.js ([#14401](#14401)) ([e0d9662](e0d9662)) * validating partial note sender ([#14379](#14379)) ([de9880c](de9880c)), closes [#14363](#14363) ### Bug Fixes * asan-fast caching ([#14468](#14468)) ([fbd9ed6](fbd9ed6)) * attempt fix concurrency ([f31e706](f31e706)) * attempt to fix merge group base config ([6aa342b](6aa342b)) * bug in `TxProvingResult` schema ([#14498](#14498)) ([#14530](#14530)) ([0ac26fa](0ac26fa)) * bump defaults ([#14474](#14474)) ([ade9a56](ade9a56)) * **docs:** Update getting started with testnet page ([#14536](#14536)) ([66fc3eb](66fc3eb)) * don't create ./out when verifying ([#14556](#14556)) ([ccb9981](ccb9981)) * eccvm_circuit_builder overrun ([#14484](#14484)) ([5e01c07](5e01c07)) * issues with syncNotes --> syncPrivateState renaming ([#14442](#14442)) ([78de410](78de410)) * Merge queue instances have pr name for uniquness in e.g. reorgs. ([#14562](#14562)) ([1f012a9](1f012a9)) * nope ([470882a](470882a)) * **playground:** fix sfpc version when creating account ([#14481](#14481)) ([5486a22](5486a22)) * processing events in contracts with no notes ([#14528](#14528)) ([1bab9b4](1bab9b4)), closes [#14499](#14499) * slack for flakes ([61829bc](61829bc)) * target branch ([e463723](e463723)) * test tracking ([#14513](#14513)) ([2d6fc3a](2d6fc3a)) * try to fix release please ([f31c07e](f31c07e)) * try to fix release please ([d402c27](d402c27)) * try to fix release please ([cb959b8](cb959b8)) * try to fix release please ([227dbd2](227dbd2)) * update sponsored fpc address in playground ([#14472](#14472)) ([4c14bc9](4c14bc9)) * wip merge master to next ([249ab4c](249ab4c)) * wip merge master to next ([b7850c9](b7850c9)) ### Miscellaneous * **bb:** avoid compile-time hash-to-curve ([#14177](#14177)) ([d3863ff](d3863ff)) * **docs:** Update alpha-testnet docs to use version 0.87.2 ([#14501](#14501)) ([c86d3b0](c86d3b0)) * master-to-next ([#14454](#14454)) ([06ac335](06ac335)) * **master:** release 0.87.3 ([#14440](#14440)) ([3ca26cd](3ca26cd)) * partial notes optimization with nullifier ([#14432](#14432)) ([cc90823](cc90823)) * playground should release also at refname. attempt to make RP do prerelease version. ([3c4fba5](3c4fba5)) * Protocol breaking changes must now go to next branch. ([#14423](#14423)) ([44304b6](44304b6)) * release 0.87.3 ([8340415](8340415)) * release please v4 ([bf97805](bf97805)) * remove some expected failures ([#13843](#13843)) ([2593e28](2593e28)) * select random rollup versions from distinct sets ([#14568](#14568)) ([fe787cd](fe787cd)) * stdlib field pre-audit pt.0 ([#14413](#14413)) ([52458c2](52458c2)) ### Documentation * comment on partial note reuse ([#14383](#14383)) ([42200c8](42200c8)) * fix image ([#14537](#14537)) ([388e79b](388e79b)), closes [#14163](#14163) * update node version instructions ([#14412](#14412)) ([a2b1b9d](a2b1b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a new Aztec Packages release --- ## [0.87.6](v0.87.5...v0.87.6) (2025-06-02) ### ⚠ BREAKING CHANGES * app benches and unified PXE creation ([#14504](#14504)) * Removes normalize() calls on pairing points ([#14285](#14285)) ### Features * Adds StarknetZK WASM bindings to bb.js ([#14372](#14372)) ([224b219](224b219)) * allow mempool to overflow before evicting ([#14641](#14641)) ([f81425d](f81425d)) * app benches and unified PXE creation ([#14504](#14504)) ([aae5ab0](aae5ab0)) * **bb:** memory tracking for microbenchmarks ([#14445](#14445)) ([fae2961](fae2961)) * enable provers to run in node chart ([#14405](#14405)) ([94edd35](94edd35)) * Ignore P2P messages previously seen ([#14665](#14665)) ([2e50588](2e50588)) * measure oracles ([#14552](#14552)) ([9cc6b54](9cc6b54)) * Removes normalize() calls on pairing points ([#14285](#14285)) ([942b948](942b948)) * Request missing txs from block proposal sender ([#14341](#14341)) ([3f97e8b](3f97e8b)) * unbundled bb.js ([#14401](#14401)) ([e0d9662](e0d9662)) * validate notes in a single node roundtrip ([#14650](#14650)) ([d467955](d467955)) * validating partial note sender ([#14379](#14379)) ([de9880c](de9880c)), closes [#14363](#14363) ### Bug Fixes * allow returning of tuples from contract funcs ([#14553](#14553)) ([1c0955c](1c0955c)) * asan-fast caching ([#14468](#14468)) ([fbd9ed6](fbd9ed6)) * attempt fix concurrency ([f31e706](f31e706)) * attempt to fix merge group base config ([6aa342b](6aa342b)) * bug in `TxProvingResult` schema ([#14498](#14498)) ([#14530](#14530)) ([0ac26fa](0ac26fa)) * bump defaults ([#14474](#14474)) ([ade9a56](ade9a56)) * do not run concurrent idb transactions ([#14609](#14609)) ([5a6f36a](5a6f36a)) * **docs:** Update create pxe interface ([#14587](#14587)) ([b3b9c05](b3b9c05)) * **docs:** Update getting started with testnet page ([#14536](#14536)) ([66fc3eb](66fc3eb)) * don't create ./out when verifying ([#14556](#14556)) ([ccb9981](ccb9981)) * Don't manually close stream on p2p/reqresp/goodbye ([#14531](#14531)) ([38cec7d](38cec7d)) * eccvm_circuit_builder overrun ([#14484](#14484)) ([5e01c07](5e01c07)) * enable bundling txs with block proposals ([#14649](#14649)) ([39b8c4e](39b8c4e)) * error on goodbye ([#14679](#14679)) ([5112f5f](5112f5f)) * issues with syncNotes --> syncPrivateState renaming ([#14442](#14442)) ([78de410](78de410)) * Merge queue instances have pr name for uniquness in e.g. reorgs. ([#14562](#14562)) ([1f012a9](1f012a9)) * nope ([470882a](470882a)) * parse LOG_LEVELS in bb ([#14674](#14674)) ([88203d6](88203d6)) * **playground:** fix sfpc version when creating account ([#14481](#14481)) ([5486a22](5486a22)) * prevent world-state from spamming the logs ([#14594](#14594)) ([8c725de](8c725de)) * processing events in contracts with no notes ([#14528](#14528)) ([1bab9b4](1bab9b4)), closes [#14499](#14499) * retrieve L1 to L2 messages in batches ([#14586](#14586)) ([2be7f1b](2be7f1b)) * slack for flakes ([61829bc](61829bc)) * target branch ([e463723](e463723)) * test tracking ([#14513](#14513)) ([2d6fc3a](2d6fc3a)) * try to fix release please ([f31c07e](f31c07e)) * try to fix release please ([d402c27](d402c27)) * try to fix release please ([cb959b8](cb959b8)) * try to fix release please ([227dbd2](227dbd2)) * update sponsored fpc address in playground ([#14472](#14472)) ([4c14bc9](4c14bc9)) * wip merge master to next ([249ab4c](249ab4c)) * wip merge master to next ([b7850c9](b7850c9)) ### Miscellaneous * add testnet compat test ([#14601](#14601)) ([1fbb350](1fbb350)) * Aztec simulator into PXE ([#14598](#14598)) ([a999c8c](a999c8c)) * **bb:** avoid compile-time hash-to-curve ([#14177](#14177)) ([d3863ff](d3863ff)) * capture RPC calls + correct timings ([#14633](#14633)) ([5ee54ff](5ee54ff)) * Disable flood publish by default ([#14635](#14635)) ([af8d879](af8d879)) * **docs:** Add scheduled typesense index job ([#14615](#14615)) ([5f42e1b](5f42e1b)) * **docs:** Update alpha-testnet docs to use version 0.87.2 ([#14501](#14501)) ([c86d3b0](c86d3b0)) * drop txs per block to 8 ([#14627](#14627)) ([369f210](369f210)) * master-to-next ([#14454](#14454)) ([06ac335](06ac335)) * **master:** release 0.87.3 ([#14440](#14440)) ([3ca26cd](3ca26cd)) * **master:** release 0.87.3 ([#14582](#14582)) ([8cea842](8cea842)) * **master:** release 0.87.4 ([#14583](#14583)) ([8077f63](8077f63)) * New prover chart for alpha-testnet ([#14514](#14514)) ([031d7cb](031d7cb)) * partial notes optimization with nullifier ([#14432](#14432)) ([cc90823](cc90823)) * playground should release also at refname. attempt to make RP do prerelease version. ([3c4fba5](3c4fba5)) * Protocol breaking changes must now go to next branch. ([#14423](#14423)) ([44304b6](44304b6)) * release 0.87.3 ([8340415](8340415)) * release please v4 ([bf97805](bf97805)) * remove some expected failures ([#13843](#13843)) ([2593e28](2593e28)) * Revert "fix: processing events in contracts with no notes ([#14528](#14528))" ([#14596](#14596)) ([3278e61](3278e61)) * select random rollup versions from distinct sets ([#14568](#14568)) ([fe787cd](fe787cd)) * stdlib field pre-audit pt.0 ([#14413](#14413)) ([52458c2](52458c2)) * trick release-please ([cbcad3d](cbcad3d)) * trick release-please ([a0c3a21](a0c3a21)) ### Documentation * comment on partial note reuse ([#14383](#14383)) ([42200c8](42200c8)) * create v0.87.4 as latest ([#14607](#14607)) ([78c2469](78c2469)) * fix image ([#14537](#14537)) ([388e79b](388e79b)), closes [#14163](#14163) * update cli ref in node doc ([#14574](#14574)) ([d54a8af](d54a8af)) * update node version instructions ([#14412](#14412)) ([a2b1b9d](a2b1b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

charlielye added 2 commits May 20, 2025 18:32

release please track next

e137089

release please workflow trigger on next

8f9a784

charlielye changed the title ~~chore: release please track next~~ chore: release please tracks next branch May 20, 2025

charlielye added 2 commits May 20, 2025 19:16

scream and shout on protocol change on master

6fbaae7

echo target branch

d92bb6f

charlielye changed the base branch from next to master May 21, 2025 11:08

charlielye added the ci-full Run all master checks. label May 21, 2025

charlielye added 2 commits May 21, 2025 12:12

add shouting test

c3ccbe0

real scream values

cff0e85

charlielye requested a review from LHerskind May 21, 2025 14:34

charlielye changed the title ~~chore: release please tracks next branch~~ chore: Protocol breaking changes must now go to next branch. May 21, 2025

flake

d3ba4f7

LHerskind reviewed May 21, 2025

View reviewed changes

wip

f40ac5b

AztecBot approved these changes May 21, 2025

View reviewed changes

charlielye added this pull request to the merge queue May 21, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2025

charlielye added 5 commits May 21, 2025 22:53

Merge branch 'master' into cl/release_please_next

2a94c28

fix l1contracts to upload generated to cache. separate benchmark outp…

ec2aa59

…uts.

Merge branch 'cl/release_please_next' of github.com:aztecprotocol/azt…

3609ecf

…ec-packages into cl/release_please_next

bump

63e031e

fix bb cache

77d6474

charlielye added this pull request to the merge queue May 22, 2025

Merged via the queue into master with commit 44304b6 May 22, 2025
4 checks passed

charlielye deleted the cl/release_please_next branch May 22, 2025 14:27

LHerskind mentioned this pull request May 22, 2025

chore: prepare scream (invalid hashes on purpose) #14414

Closed

This was referenced May 28, 2025

chore(next): release 0.88.0 #14495

Closed

chore(master): release 0.87.3 #14582

Merged

This was referenced May 29, 2025

chore(master): release 0.87.3 #14602

Closed

chore(master): release 0.87.6 #14651

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Protocol breaking changes must now go to next branch.#14423

chore: Protocol breaking changes must now go to next branch.#14423
charlielye merged 13 commits intomasterfrom
cl/release_please_next

charlielye commented May 20, 2025 •

edited

Loading

Uh oh!

LHerskind May 21, 2025 •

edited

Loading

Uh oh!

LHerskind May 21, 2025

Uh oh!

fcarreiro commented May 21, 2025

Uh oh!

Uh oh!

charlielye commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	echo "$hash cd l1-contracts && forge test --no-match-contract UniswapPortalTest"
	echo "$hash cd l1-contracts && forge test"

Conversation

charlielye commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LHerskind May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LHerskind May 21, 2025

Choose a reason for hiding this comment

Uh oh!

fcarreiro commented May 21, 2025

Uh oh!

Uh oh!

charlielye commented May 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

charlielye commented May 20, 2025 •

edited

Loading

LHerskind May 21, 2025 •

edited

Loading