feat!: Removes normalize() calls on pairing points by lucasxia01 · Pull Request #14285 · AztecProtocol/aztec-packages

lucasxia01 · 2025-05-13T21:24:00Z

Also closes AztecProtocol/barretenberg#1352. We use real biggroup elements in the dummy witness case for the points in the public inputs, so there shouldn't be a need for random normalize calls.

Adds pairing points test that also outputs the number of gates associated with pairing points operations like constructing default.

…tes (20)

lucasxia01 · 2025-05-15T12:34:44Z

barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp


    DeciderVerifier decider_verifier{ verification_key, transcript };
    auto decider_output = decider_verifier.verify();
+    if (!decider_output.sumcheck_verified) {


because I added an assert to aggregate() that checks that the points are initialized with some real points (and not the points at infinity), we need to return early here, otherwise I would've had to change a bunch of tests from ASSERT_FALSE to ASSERT_DEATH, and I was too lazy to do that

lucasxia01 · 2025-05-15T12:35:23Z

barretenberg/cpp/src/barretenberg/vm2/constraining/recursion/recursive_verifier.cpp

    auto pairing_points = PCS::reduce_verify_batch_opening_claim(opening_claim, transcript);
-
-    // TODO(https://github.com/AztecProtocol/barretenberg/issues/1352): Investigate if normalize() calls are needed.
-    pairing_points[0] = pairing_points[0].normalize();


hopefully, we won't hit random maximum_value failures in bigfield now that we set the dummy pairing points to be actual points and not arbitrary values

lucasxia01 · 2025-05-15T12:36:44Z

barretenberg/cpp/src/barretenberg/stdlib/plonk_recursion/pairing_points.hpp

        return { P0, P1 };
    }
+
+    static std::array<fr, PUBLIC_INPUTS_SIZE> construct_dummy_pairing_points()


probably needs to some cleanup because this is largely duplicated, but we want this to set the dummy pairing points inputs (for the write_vk case).

lucasxia01 · 2025-05-15T12:37:00Z

barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ultra_recursive_verifier.test.cpp

        // Check the size of the recursive verifier
        if constexpr (std::same_as<RecursiveFlavor, MegaZKRecursiveFlavor_<UltraCircuitBuilder>>) {
-            uint32_t NUM_GATES_EXPECTED = 871733;
+            uint32_t NUM_GATES_EXPECTED = 871531;


drop because we removed normalize() calls

…ing-points-normalize-calls

…ents

ledwards2225

core changes look ok but a few things to address here before we merge

barretenberg/cpp/src/barretenberg/stdlib/pairing_points.test.cpp

barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_builder_base_impl.hpp

yarn-project/end-to-end/src/fixtures/get_bb_config.ts

yarn-project/ivc-integration/src/native_client_ivc_integration.test.ts

ledwards2225 · 2025-05-20T22:29:12Z

barretenberg/cpp/scripts/test_civc_standalone_vks_havent_changed.sh

 # - Generate inputs: $root/yarn-project/end-to-end/bootstrap.sh generate_example_app_ivc_inputs
 # - Upload the compressed results: aws s3 cp bb-civc-inputs-[version].tar.gz s3://aztec-ci-artifacts/protocol/bb-civc-inputs-[version].tar.gz
-pinned_civc_inputs_url="https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/protocol/bb-civc-inputs-v7.tar.gz"
+pinned_civc_inputs_url="https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/protocol/bb-civc-inputs-7f48a235.tar.gz"


I think these should be kept in sync with the ones in generate_civc_vks.sh no? We should probably setting this in one location and sharing it where needed

Also closes AztecProtocol/barretenberg#1352. We use real biggroup elements in the dummy witness case for the points in the public inputs, so there shouldn't be a need for random normalize calls. Adds pairing points test that also outputs the number of gates associated with pairing points operations like constructing default and aggregate.

This reverts commit 942b948.

This reverts commit 49ebe93.

🤖 I have created a release *beep* *boop* --- ## [0.87.3](v0.87.2...v0.87.3) (2025-05-22) ### ⚠ BREAKING CHANGES * Removes normalize() calls on pairing points ([#14285](#14285)) ### Features * Adds StarknetZK WASM bindings to bb.js ([#14372](#14372)) ([224b219](224b219)) * Removes normalize() calls on pairing points ([#14285](#14285)) ([942b948](942b948)) * unbundled bb.js ([#14401](#14401)) ([e0d9662](e0d9662)) * validating partial note sender ([#14379](#14379)) ([de9880c](de9880c)), closes [#14363](#14363) ### Bug Fixes * bump defaults ([#14474](#14474)) ([ade9a56](ade9a56)) * eccvm_circuit_builder overrun ([#14484](#14484)) ([5e01c07](5e01c07)) * issues with syncNotes --> syncPrivateState renaming ([#14442](#14442)) ([78de410](78de410)) * **playground:** fix sfpc version when creating account ([#14481](#14481)) ([5486a22](5486a22)) * update sponsored fpc address in playground ([#14472](#14472)) ([4c14bc9](4c14bc9)) * wip merge master to next ([249ab4c](249ab4c)) * wip merge master to next ([b7850c9](b7850c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com> Co-authored-by: saleel <saleel@saleel.xyz> Co-authored-by: James Zaki <james.zaki@proton.me>

🤖 I have created a new Aztec Packages release --- ## [0.87.3](v0.87.2...v0.87.3) (2025-05-28) ### ⚠ BREAKING CHANGES * app benches and unified PXE creation ([#14504](#14504)) * Removes normalize() calls on pairing points ([#14285](#14285)) ### Features * Adds StarknetZK WASM bindings to bb.js ([#14372](#14372)) ([224b219](224b219)) * app benches and unified PXE creation ([#14504](#14504)) ([aae5ab0](aae5ab0)) * **bb:** memory tracking for microbenchmarks ([#14445](#14445)) ([fae2961](fae2961)) * enable provers to run in node chart ([#14405](#14405)) ([94edd35](94edd35)) * measure oracles ([#14552](#14552)) ([9cc6b54](9cc6b54)) * Removes normalize() calls on pairing points ([#14285](#14285)) ([942b948](942b948)) * unbundled bb.js ([#14401](#14401)) ([e0d9662](e0d9662)) * validating partial note sender ([#14379](#14379)) ([de9880c](de9880c)), closes [#14363](#14363) ### Bug Fixes * asan-fast caching ([#14468](#14468)) ([fbd9ed6](fbd9ed6)) * attempt fix concurrency ([f31e706](f31e706)) * attempt to fix merge group base config ([6aa342b](6aa342b)) * bug in `TxProvingResult` schema ([#14498](#14498)) ([#14530](#14530)) ([0ac26fa](0ac26fa)) * bump defaults ([#14474](#14474)) ([ade9a56](ade9a56)) * **docs:** Update getting started with testnet page ([#14536](#14536)) ([66fc3eb](66fc3eb)) * don't create ./out when verifying ([#14556](#14556)) ([ccb9981](ccb9981)) * eccvm_circuit_builder overrun ([#14484](#14484)) ([5e01c07](5e01c07)) * issues with syncNotes --> syncPrivateState renaming ([#14442](#14442)) ([78de410](78de410)) * Merge queue instances have pr name for uniquness in e.g. reorgs. ([#14562](#14562)) ([1f012a9](1f012a9)) * nope ([470882a](470882a)) * **playground:** fix sfpc version when creating account ([#14481](#14481)) ([5486a22](5486a22)) * processing events in contracts with no notes ([#14528](#14528)) ([1bab9b4](1bab9b4)), closes [#14499](#14499) * slack for flakes ([61829bc](61829bc)) * target branch ([e463723](e463723)) * test tracking ([#14513](#14513)) ([2d6fc3a](2d6fc3a)) * try to fix release please ([f31c07e](f31c07e)) * try to fix release please ([d402c27](d402c27)) * try to fix release please ([cb959b8](cb959b8)) * try to fix release please ([227dbd2](227dbd2)) * update sponsored fpc address in playground ([#14472](#14472)) ([4c14bc9](4c14bc9)) * wip merge master to next ([249ab4c](249ab4c)) * wip merge master to next ([b7850c9](b7850c9)) ### Miscellaneous * **bb:** avoid compile-time hash-to-curve ([#14177](#14177)) ([d3863ff](d3863ff)) * **docs:** Update alpha-testnet docs to use version 0.87.2 ([#14501](#14501)) ([c86d3b0](c86d3b0)) * master-to-next ([#14454](#14454)) ([06ac335](06ac335)) * **master:** release 0.87.3 ([#14440](#14440)) ([3ca26cd](3ca26cd)) * partial notes optimization with nullifier ([#14432](#14432)) ([cc90823](cc90823)) * playground should release also at refname. attempt to make RP do prerelease version. ([3c4fba5](3c4fba5)) * Protocol breaking changes must now go to next branch. ([#14423](#14423)) ([44304b6](44304b6)) * release 0.87.3 ([8340415](8340415)) * release please v4 ([bf97805](bf97805)) * remove some expected failures ([#13843](#13843)) ([2593e28](2593e28)) * select random rollup versions from distinct sets ([#14568](#14568)) ([fe787cd](fe787cd)) * stdlib field pre-audit pt.0 ([#14413](#14413)) ([52458c2](52458c2)) ### Documentation * comment on partial note reuse ([#14383](#14383)) ([42200c8](42200c8)) * fix image ([#14537](#14537)) ([388e79b](388e79b)), closes [#14163](#14163) * update node version instructions ([#14412](#14412)) ([a2b1b9d](a2b1b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a new Aztec Packages release --- ## [0.87.6](v0.87.5...v0.87.6) (2025-06-02) ### ⚠ BREAKING CHANGES * app benches and unified PXE creation ([#14504](#14504)) * Removes normalize() calls on pairing points ([#14285](#14285)) ### Features * Adds StarknetZK WASM bindings to bb.js ([#14372](#14372)) ([224b219](224b219)) * allow mempool to overflow before evicting ([#14641](#14641)) ([f81425d](f81425d)) * app benches and unified PXE creation ([#14504](#14504)) ([aae5ab0](aae5ab0)) * **bb:** memory tracking for microbenchmarks ([#14445](#14445)) ([fae2961](fae2961)) * enable provers to run in node chart ([#14405](#14405)) ([94edd35](94edd35)) * Ignore P2P messages previously seen ([#14665](#14665)) ([2e50588](2e50588)) * measure oracles ([#14552](#14552)) ([9cc6b54](9cc6b54)) * Removes normalize() calls on pairing points ([#14285](#14285)) ([942b948](942b948)) * Request missing txs from block proposal sender ([#14341](#14341)) ([3f97e8b](3f97e8b)) * unbundled bb.js ([#14401](#14401)) ([e0d9662](e0d9662)) * validate notes in a single node roundtrip ([#14650](#14650)) ([d467955](d467955)) * validating partial note sender ([#14379](#14379)) ([de9880c](de9880c)), closes [#14363](#14363) ### Bug Fixes * allow returning of tuples from contract funcs ([#14553](#14553)) ([1c0955c](1c0955c)) * asan-fast caching ([#14468](#14468)) ([fbd9ed6](fbd9ed6)) * attempt fix concurrency ([f31e706](f31e706)) * attempt to fix merge group base config ([6aa342b](6aa342b)) * bug in `TxProvingResult` schema ([#14498](#14498)) ([#14530](#14530)) ([0ac26fa](0ac26fa)) * bump defaults ([#14474](#14474)) ([ade9a56](ade9a56)) * do not run concurrent idb transactions ([#14609](#14609)) ([5a6f36a](5a6f36a)) * **docs:** Update create pxe interface ([#14587](#14587)) ([b3b9c05](b3b9c05)) * **docs:** Update getting started with testnet page ([#14536](#14536)) ([66fc3eb](66fc3eb)) * don't create ./out when verifying ([#14556](#14556)) ([ccb9981](ccb9981)) * Don't manually close stream on p2p/reqresp/goodbye ([#14531](#14531)) ([38cec7d](38cec7d)) * eccvm_circuit_builder overrun ([#14484](#14484)) ([5e01c07](5e01c07)) * enable bundling txs with block proposals ([#14649](#14649)) ([39b8c4e](39b8c4e)) * error on goodbye ([#14679](#14679)) ([5112f5f](5112f5f)) * issues with syncNotes --> syncPrivateState renaming ([#14442](#14442)) ([78de410](78de410)) * Merge queue instances have pr name for uniquness in e.g. reorgs. ([#14562](#14562)) ([1f012a9](1f012a9)) * nope ([470882a](470882a)) * parse LOG_LEVELS in bb ([#14674](#14674)) ([88203d6](88203d6)) * **playground:** fix sfpc version when creating account ([#14481](#14481)) ([5486a22](5486a22)) * prevent world-state from spamming the logs ([#14594](#14594)) ([8c725de](8c725de)) * processing events in contracts with no notes ([#14528](#14528)) ([1bab9b4](1bab9b4)), closes [#14499](#14499) * retrieve L1 to L2 messages in batches ([#14586](#14586)) ([2be7f1b](2be7f1b)) * slack for flakes ([61829bc](61829bc)) * target branch ([e463723](e463723)) * test tracking ([#14513](#14513)) ([2d6fc3a](2d6fc3a)) * try to fix release please ([f31c07e](f31c07e)) * try to fix release please ([d402c27](d402c27)) * try to fix release please ([cb959b8](cb959b8)) * try to fix release please ([227dbd2](227dbd2)) * update sponsored fpc address in playground ([#14472](#14472)) ([4c14bc9](4c14bc9)) * wip merge master to next ([249ab4c](249ab4c)) * wip merge master to next ([b7850c9](b7850c9)) ### Miscellaneous * add testnet compat test ([#14601](#14601)) ([1fbb350](1fbb350)) * Aztec simulator into PXE ([#14598](#14598)) ([a999c8c](a999c8c)) * **bb:** avoid compile-time hash-to-curve ([#14177](#14177)) ([d3863ff](d3863ff)) * capture RPC calls + correct timings ([#14633](#14633)) ([5ee54ff](5ee54ff)) * Disable flood publish by default ([#14635](#14635)) ([af8d879](af8d879)) * **docs:** Add scheduled typesense index job ([#14615](#14615)) ([5f42e1b](5f42e1b)) * **docs:** Update alpha-testnet docs to use version 0.87.2 ([#14501](#14501)) ([c86d3b0](c86d3b0)) * drop txs per block to 8 ([#14627](#14627)) ([369f210](369f210)) * master-to-next ([#14454](#14454)) ([06ac335](06ac335)) * **master:** release 0.87.3 ([#14440](#14440)) ([3ca26cd](3ca26cd)) * **master:** release 0.87.3 ([#14582](#14582)) ([8cea842](8cea842)) * **master:** release 0.87.4 ([#14583](#14583)) ([8077f63](8077f63)) * New prover chart for alpha-testnet ([#14514](#14514)) ([031d7cb](031d7cb)) * partial notes optimization with nullifier ([#14432](#14432)) ([cc90823](cc90823)) * playground should release also at refname. attempt to make RP do prerelease version. ([3c4fba5](3c4fba5)) * Protocol breaking changes must now go to next branch. ([#14423](#14423)) ([44304b6](44304b6)) * release 0.87.3 ([8340415](8340415)) * release please v4 ([bf97805](bf97805)) * remove some expected failures ([#13843](#13843)) ([2593e28](2593e28)) * Revert "fix: processing events in contracts with no notes ([#14528](#14528))" ([#14596](#14596)) ([3278e61](3278e61)) * select random rollup versions from distinct sets ([#14568](#14568)) ([fe787cd](fe787cd)) * stdlib field pre-audit pt.0 ([#14413](#14413)) ([52458c2](52458c2)) * trick release-please ([cbcad3d](cbcad3d)) * trick release-please ([a0c3a21](a0c3a21)) ### Documentation * comment on partial note reuse ([#14383](#14383)) ([42200c8](42200c8)) * create v0.87.4 as latest ([#14607](#14607)) ([78c2469](78c2469)) * fix image ([#14537](#14537)) ([388e79b](388e79b)), closes [#14163](#14163) * update cli ref in node doc ([#14574](#14574)) ([d54a8af](d54a8af)) * update node version instructions ([#14412](#14412)) ([a2b1b9d](a2b1b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

try removing normalize() calls

1600053

lucasxia01 requested review from IlyasRidhuan, fcarreiro and jeanmon as code owners May 13, 2025 21:24

fcarreiro removed their request for review May 13, 2025 21:29

lucasxia01 changed the title ~~chore: remove normalize() calls~~ feat!: Removes gates for generating default pairing points May 14, 2025

fix add_default_to_public_inputs for pairing points to add minimal ga…

8fea826

…tes (20)

lucasxia01 self-assigned this May 14, 2025

fix build and tests

4c8e4e1

lucasxia01 commented May 15, 2025

View reviewed changes

lucasxia01 added 10 commits May 15, 2025 12:52

Merge remote-tracking branch 'origin/master' into lx/investigate-pair…

dd99736

…ing-points-normalize-calls

Merge remote-tracking branch 'origin/master' into lx/investigate-pair…

dd6fd77

…ing-points-normalize-calls

refactor and rework things to construct dummy public input group elem…

fc591f8

…ents

Merge branch 'master' into lx/investigate-pairing-points-normalize-calls

13f55b8

try reverting change to add_default

931c29e

remove circuit checker

cb4c5a8

hack around standalone vks test

3fb7adc

remove pairing checks in aggregate

eaf091c

whoops, these changes are the ones i wanted

a96c1c4

ignore standalone vk test

4a23614

lucasxia01 added the ci-full Run all master checks. label May 19, 2025

lucasxia01 added 3 commits May 20, 2025 21:42

pls

a4cb309

remove debugging stuff

bbcf1a4

undo small changes

6f6e493

ledwards2225 approved these changes May 20, 2025

View reviewed changes

clean up whoops

badfefc

lucasxia01 changed the title ~~feat!: Removes gates for generating default pairing points~~ feat!: Removes normalize() calls on pairing points May 21, 2025

lucasxia01 added this pull request to the merge queue May 21, 2025

Merged via the queue into master with commit 942b948 May 21, 2025
7 checks passed

lucasxia01 deleted the lx/investigate-pairing-points-normalize-calls branch May 21, 2025 16:40

This was referenced May 21, 2025

chore(master): release 0.87.3 #14440

Merged

chore(next): release 1.0.0 #14467

Closed

chore(next): release 0.88.0 #14495

Closed

saleel added a commit that referenced this pull request May 23, 2025

Revert "feat!: Removes normalize() calls on pairing points (#14285)"

257d387

This reverts commit 942b948.

ludamad added a commit that referenced this pull request May 23, 2025

Revert "feat!: Removes normalize() calls on pairing points (#14285)"

49ebe93

This reverts commit 942b948.

ludamad added a commit that referenced this pull request May 23, 2025

Reapply "feat!: Removes normalize() calls on pairing points (#14285)"

61d3ad1

This reverts commit 49ebe93.

AztecBot mentioned this pull request May 28, 2025

chore(master): release 0.87.3 #14582

Merged

This was referenced May 29, 2025

chore(master): release 0.87.3 #14602

Closed

chore(master): release 0.87.6 #14651

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Removes normalize() calls on pairing points#14285

feat!: Removes normalize() calls on pairing points#14285
lucasxia01 merged 17 commits intomasterfrom
lx/investigate-pairing-points-normalize-calls

lucasxia01 commented May 13, 2025 •

edited

Loading

Uh oh!

lucasxia01 May 15, 2025

Uh oh!

lucasxia01 May 15, 2025

Uh oh!

lucasxia01 May 15, 2025

Uh oh!

lucasxia01 May 15, 2025

Uh oh!

ledwards2225 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ledwards2225 May 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lucasxia01 commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucasxia01 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

lucasxia01 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

lucasxia01 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

lucasxia01 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

ledwards2225 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ledwards2225 May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lucasxia01 commented May 13, 2025 •

edited

Loading