Skip to content

refactor: improved readability AztecNodeService.getL2ToL1MessageMembershipWitness#14273

Merged
benesjan merged 4 commits intomasterfrom
05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness
May 21, 2025
Merged

refactor: improved readability AztecNodeService.getL2ToL1MessageMembershipWitness#14273
benesjan merged 4 commits intomasterfrom
05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness

Conversation

@benesjan
Copy link
Contributor

Felt like the function's readability could be improved so I did that. Used AI a lot for this so some changes might be a bit unnecessary. Complexity of the PR is low though so felt like the bad diff of the function code is fine.

Copy link
Contributor Author

benesjan commented May 13, 2025

@benesjan benesjan marked this pull request as ready for review May 13, 2025 16:23
@benesjan benesjan requested a review from MirandaWood May 13, 2025 16:24
@benesjan benesjan force-pushed the 05-13-test_making_l2_to_l1_test_cute branch from 4ec59d7 to 42f55b2 Compare May 13, 2025 17:14
@benesjan benesjan force-pushed the 05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness branch from 02ea7ed to 246fc78 Compare May 13, 2025 17:14
@benesjan benesjan force-pushed the 05-13-test_making_l2_to_l1_test_cute branch from 42f55b2 to 1d46d08 Compare May 14, 2025 09:12
@benesjan benesjan force-pushed the 05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness branch from 3b6a63e to aec4877 Compare May 14, 2025 09:12
Base automatically changed from 05-13-test_making_l2_to_l1_test_cute to master May 14, 2025 10:09
@benesjan benesjan force-pushed the 05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness branch from aec4877 to 21fc7d3 Compare May 14, 2025 10:10
Copy link
Contributor

@MirandaWood MirandaWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@benesjan benesjan force-pushed the 05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness branch from 21fc7d3 to 140fb09 Compare May 21, 2025 09:19
@benesjan benesjan enabled auto-merge May 21, 2025 09:19
@benesjan benesjan added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 038a518 May 21, 2025
5 checks passed
@benesjan benesjan deleted the 05-13-refactor_improved_readability_aztecnodeservice.getl2tol1messagemembershipwitness branch May 21, 2025 10:22
charlielye pushed a commit that referenced this pull request May 21, 2025
🤖 I have created a new Aztec Packages release
---


##
[0.87.2](v0.87.1...v0.87.2)
(2025-05-21)


### Miscellaneous

* improved readability
AztecNodeService.getL2ToL1MessageMembershipWitness
([#14273](#14273))
([038a518](038a518))
* rename invalid block num to invalid max block num
([#13894](#13894))
([0db31ce](0db31ce))
* syncNotes --> syncPrivateState
([#14438](#14438))
([845830a](845830a)),
closes
[#13113](#13113)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Thunkar pushed a commit that referenced this pull request May 23, 2025
…rshipWitness (#14273)

Felt like the function's readability could be improved so I did that.
Used AI a lot for this so some changes might be a bit unnecessary.
Complexity of the PR is low though so felt like the bad diff of the
function code is fine.
Thunkar pushed a commit that referenced this pull request May 23, 2025
🤖 I have created a new Aztec Packages release
---


##
[0.87.2](v0.87.1...v0.87.2)
(2025-05-21)


### Miscellaneous

* improved readability
AztecNodeService.getL2ToL1MessageMembershipWitness
([#14273](#14273))
([038a518](038a518))
* rename invalid block num to invalid max block num
([#13894](#13894))
([0db31ce](0db31ce))
* syncNotes --> syncPrivateState
([#14438](#14438))
([845830a](845830a)),
closes
[#13113](#13113)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants