test: merging e2e_outbox with l2_to_l1 test#14246
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
May 13, 2025
| 60_000, | ||
| ); | ||
|
|
||
| it('Inserts a new transaction with two out messages, and verifies sibling paths of both the new messages', async () => { |
Contributor
Author
There was a problem hiding this comment.
What follows is essentially just a copy paste from e2e_outbox and does not need to be thoroughly reviewed.
MirandaWood
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made no sense to have these 2 tests separated as they test the same thing (L2 to L1 messaging). Decided to tackle this tech debt task now as it confused me when debugging a related issue (incorrectly assumed a feature is untested while the test was hidden in the outbox test).