chore: rename invalid block num to invalid max block num#13894
Merged
chore: rename invalid block num to invalid max block num#13894
Conversation
alexghr
approved these changes
May 21, 2025
charlielye
pushed a commit
that referenced
this pull request
May 21, 2025
🤖 I have created a new Aztec Packages release --- ## [0.87.2](v0.87.1...v0.87.2) (2025-05-21) ### Miscellaneous * improved readability AztecNodeService.getL2ToL1MessageMembershipWitness ([#14273](#14273)) ([038a518](038a518)) * rename invalid block num to invalid max block num ([#13894](#13894)) ([0db31ce](0db31ce)) * syncNotes --> syncPrivateState ([#14438](#14438)) ([845830a](845830a)), closes [#13113](#13113) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thunkar
pushed a commit
that referenced
this pull request
May 23, 2025
We currently error out with 'invalid block number' when we detect a tx's _max_ block number as being invalid, I updated the error message to clarify this. I assume we don't consider this a breaking change. Closes #13622
Thunkar
pushed a commit
that referenced
this pull request
May 23, 2025
🤖 I have created a new Aztec Packages release --- ## [0.87.2](v0.87.1...v0.87.2) (2025-05-21) ### Miscellaneous * improved readability AztecNodeService.getL2ToL1MessageMembershipWitness ([#14273](#14273)) ([038a518](038a518)) * rename invalid block num to invalid max block num ([#13894](#13894)) ([0db31ce](0db31ce)) * syncNotes --> syncPrivateState ([#14438](#14438)) ([845830a](845830a)), closes [#13113](#13113) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently error out with 'invalid block number' when we detect a tx's max block number as being invalid, I updated the error message to clarify this. I assume we don't consider this a breaking change.
Closes #13622