Fixes for sequencer, aztec js, world state#123
Merged
spalladino merged 5 commits intomasterfrom Mar 29, 2023
Merged
Conversation
spalladino
force-pushed
the
fix/circuit-block-builder
branch
from
60634e4 to
84effb7
Compare
spalladino
changed the title
ludamad
added a commit
that referenced
this pull request
Jul 14, 2023
…llup/ removal, kesha's bigfield fix) (#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (#14) * Add cmake logic to support building of dependent C++/WASM projects (#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
…llup/ removal, kesha's bigfield fix) (#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (#14) * Add cmake logic to support building of dependent C++/WASM projects (#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
10 tasks
AztecBot
pushed a commit
that referenced
this pull request
Oct 20, 2025
## Problem When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with `Closes #123` remain open even after the PR eventually merges to `next`. Recognizes cross-repo references and various `resolves` `fixes` etc
AztecBot
pushed a commit
that referenced
this pull request
Oct 20, 2025
## Problem When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with `Closes #123` remain open even after the PR eventually merges to `next`. Recognizes cross-repo references and various `resolves` `fixes` etc
ludamad
added a commit
that referenced
this pull request
Oct 23, 2025
This adds automation to automatically close GitHub issues that are referenced in pull requests when those PRs are merged to the default branch (next). Problem: When PRs target intermediate branches (like merge-train branches) instead of the main branch, GitHub's native auto-close functionality doesn't work. For example, if a PR says "Closes #1234" but targets a merge-train branch, issue #1234 won't be automatically closed when the PR is eventually merged to next. Solution: This automation processes all new commits pushed to next and closes any issues referenced in the merged PRs using the Aztec bot. Components: - GitHub Actions workflow (.github/workflows/auto-close-issues.yml) that triggers on push to next branch - Python script (scripts/auto_close_issues.py) that processes commits and closes referenced issues - Analysis script (scripts/find_orphaned_issues_in_prs.py) for finding historical orphaned issues The solution works with any commit type (merge, squash, rebase) and supports multiple issue reference formats: - URL format: https://github.com/owner/repo/issues/123 - Cross-repo: owner/repo#123 - Same-repo: #123 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ludamad
added a commit
that referenced
this pull request
Oct 23, 2025
Enhanced both auto_close_issues.py and find_orphaned_issues_in_prs.py to extract GitHub issue URLs (https://github.com/owner/repo/issues/123) even without close/fix/resolve keywords. This handles cases like PR #17830 where issues are referenced via URL in the PR body without explicit keywords. Supported formats: - URL: https://github.com/owner/repo/issues/123 (new) - Cross-repo: owner/repo#123 - Same-repo: #123 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
AztecBot
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Problem When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with `Closes #123` remain open even after the PR eventually merges to `next`. Recognizes cross-repo references and various `resolves` `fixes` etc
7 tasks
ludamad
added a commit
that referenced
this pull request
Apr 16, 2026
Codify how Claude should write code comments in this repo, sourced from
ruff's AGENTS.md ('use comments purposefully; do not narrate code'),
seed-hypermedia/seed's AGENTS.md ('avoid banner-style comments splitting
the file into sections'), and the system-prompt guidance that not every
contributor's Claude session will inherit.
Each paragraph passes the <editorial_test>:
- 'default to no comments' prevents Claude decorating each block with
explanatory prose that bloats diffs and repeats identifier names.
- 'don't explain what, only why' prevents '// increment counter'-style
narration that rots as soon as the code next to it changes.
- 'don't reference the current task/PR/caller/author' prevents
'// Fix for issue #123' / '// used by X' / '// AI-generated' comments
that hard-code context which belongs in the PR description and rots
when code moves.
- 'no banner-style section comments' prevents '// ===== HELPERS ====='
markers that stale the moment a function is moved.
Move the '// AI-generated' comment prohibition from <attribution> into
<writing_comments> since it's a comment rule, not a git-attribution rule.
Leave <attribution> covering only git trailers and PR descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.