Conversation
AztecBot
added
ci-draft
AztecBot
force-pushed
the
claudebox/f18c94945cd45704-3
branch
2 times, most recently
from
fc1876c to
d92d6f6
Compare
AztecBot
changed the title
|
/claudebox please iterate on feedback here |
|
⏳ Run #1 — Session completed (5m) Pushed review feedback fixes to #22473 — addressed all 6 comments (merge-train generalization, PR diff guidance, post-edit hook note, removed duplicate commit messages section, removed retrospective agent). Details: https://gist.github.com/AztecBot/72f1d7499c23bbde6304503cac391d6f |
ludamad
force-pushed
the
claudebox/f18c94945cd45704-3
branch
from
370261e to
264878d
Compare
ludamad
changed the title
…neric rules Delete yarn-project/.claude/rules/ entirely — same treatment as the root .claude/rules/ deletion in the first commit. The directory had unreliable auto-loading semantics confirmed experimentally on PR #22473. Content is now inlined into yarn-project/CLAUDE.md as XML-tagged sections: <typescript_style> with nested <type_safety>, <type_colocation>, <data_structures>, <error_handling>, <class_style>, <jsdoc>, <enums_and_unions>, <resource_management>, <kv_store_transactions>, <general_style>, <code_duplication>, <collections_and_maps>, <logging>, <import_organization>, <event_handling> <ci_config> for the flaky-test pattern markup Code examples from the original typescript-style.md are dropped in favor of concise rule statements — the rules are actionable on their own, and the codebase itself serves as the canonical example set. Root CLAUDE.md gains five new generic XML sections: <test_behavior_not_mocks> — sourced from selfxyz/self CLAUDE.md: "Prefer tests that validate behavior. Avoid tests that only assert mocks were called unless that is the behavior being validated." <reuse_before_writing> — sourced from selfxyz/self CLAUDE.md: "Before writing new code, search for existing utilities/components/ flows and reuse or refactor to shared modules." <making_decisions> — sourced from selfxyz/self CLAUDE.md: "Make decisions, not options." <preserve_todos> — sourced from ShieldBattery/ShieldBattery AGENTS.md: "Preserve TODO(context) and NOTE(context) comments unless completing the TODO." <no_single_file_folders> — sourced from selfxyz/self CLAUDE.md: "Do not create a folder that exists only to hold one markdown file." yarn-project/CLAUDE.md also gains a <type_colocation> rule sourced from ShieldBattery/ShieldBattery AGENTS.md, and the Dependency Management section now explains the tsconfig project-references regeneration workflow via yarn prepare, sourced from MetaMask/ocap-kernel AGENTS.md.
|
@spalladino some changes here, still needs some tweaking but I appreciate your feedback |
|
@ludamad my feedback is why are you working on this PR at 9pm while on vacation 
|
| # Regression test for the layout rule: every subdir that owns its own .claude/ | ||
| # must symlink agents/ to the repository root's .claude/agents/. Without the | ||
| # symlink, Claude Code's upward-walk stops at the subdir .claude/ and silently | ||
| # shadows every root agent. |
There was a problem hiding this comment.
Good catch. Does this apply to other folders as well, like skills?
There was a problem hiding this comment.
It would cause skills to be loaded multiple times I think. They are loaded dynamically just fine
|
|
||
| ``` | ||
|
|
||
| <typescript_style> |
There was a problem hiding this comment.
Why the move to these tags? I understand why no shared rules in top-level, but why not here?
There was a problem hiding this comment.
Rules just don't compose well. These way they get naturally included as yp is mentioned. It's better imo. I'd defer to you
There was a problem hiding this comment.
Imo let's use rules only if we use front matter which Claude.md can't do. Are you okay with that rule?
There was a problem hiding this comment.
I genuinely believe that XML tags work best here. Anthropic would have abandoned them for their system prompt if not.
There was a problem hiding this comment.
I have no idea of which of the two works best. I like rules because they are split across multiple files and are easier for humans to parse. But if this works better for Claude, let's stick with this.
It hasn't been pushed to in a while! Trying to do my friend Claude a favour |
|
But ofc everyone do as palla says not as I do |
|
@spalladino okay it should be ready for another look. Eager to get this in, but want to get it in right, so don't feel bad if you think anything needs rethinking |
ludamad
changed the title
ludamad
changed the title
## Summary Reworks `.claude/` layout and CLAUDE.md files across the monorepo. Takes inspiration from the claude system prompt (XML tags) and a other repos (e.g. a lack of rules files). Included a few wishlist items from the team, and rearranged according to the new idea of claude organization. Co-authored-by: ludamad <adam.domurad@gmail.com>
AztecBot
force-pushed
the
claudebox/f18c94945cd45704-3
branch
from
f0142da to
d6e2372
Compare
5 participants
Summary
Reworks
.claude/layout and CLAUDE.md files across the monorepo. Takes inspiration from the claude system prompt (XML tags) and a other repos (e.g. a lack of rules files). Included a few wishlist items from the team, and rearranged according to the new idea of claude organization.