Skip to content

feat: auto-close issues from merge commits to default branch#17828

Merged
ludamad merged 1 commit intonextfrom
ad/feat/auto-close-issues-from-merge-commits
Oct 24, 2025
Merged

feat: auto-close issues from merge commits to default branch#17828
ludamad merged 1 commit intonextfrom
ad/feat/auto-close-issues-from-merge-commits

Conversation

@ludamad
Copy link
Copy Markdown
Collaborator

@ludamad ludamad commented Oct 20, 2025

Problem

When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with Closes #123 remain open even after the PR eventually merges to next.

Recognizes cross-repo references and various resolves fixes etc

@ludamad ludamad requested a review from charlielye as a code owner October 20, 2025 18:50
@ludamad ludamad force-pushed the ad/feat/auto-close-issues-from-merge-commits branch 12 times, most recently from c341975 to f976ea3 Compare October 20, 2025 21:42
@ludamad ludamad enabled auto-merge October 20, 2025 21:58
@AztecBot AztecBot force-pushed the ad/feat/auto-close-issues-from-merge-commits branch from f976ea3 to c5f24e2 Compare October 20, 2025 22:02
@AztecBot AztecBot force-pushed the ad/feat/auto-close-issues-from-merge-commits branch from c5f24e2 to 47b7bf6 Compare October 20, 2025 22:05
Copy link
Copy Markdown
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only nit from me is for it to pick the url form also not only the #issue number form

@ludamad ludamad added this pull request to the merge queue Oct 21, 2025
@sirasistant sirasistant removed this pull request from the merge queue due to a manual request Oct 21, 2025
@ludamad ludamad force-pushed the ad/feat/auto-close-issues-from-merge-commits branch from 47b7bf6 to f3355ee Compare October 23, 2025 16:28
## Problem

When PRs target intermediate branches (e.g., merge-train) instead of the main branch, GitHub's native auto-close functionality doesn't work. Issues referenced with `Closes #123` remain open even after the PR eventually merges to `next`.

Recognizes cross-repo references and various `resolves` `fixes` etc
@AztecBot AztecBot force-pushed the ad/feat/auto-close-issues-from-merge-commits branch from 03981ca to 7babc80 Compare October 23, 2025 21:19
@ludamad ludamad added this pull request to the merge queue Oct 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2025
@ludamad ludamad merged commit 660c66d into next Oct 24, 2025
14 checks passed
@ludamad ludamad deleted the ad/feat/auto-close-issues-from-merge-commits branch October 24, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants