fix(ci): don't have checks go green immediately#12168
Merged
Conversation
ludamad
force-pushed
the
ad/fix/ci3-workflow
branch
from
0b6f80b to
8dd98e7
Compare
Collaborator
Author
|
Note pull request target will show as skipped because it does not yet honour the paths ignore attribute (it's looking at master's workflow) |
spalladino
approved these changes
Feb 20, 2025
Contributor
|
Looks good, but I'd advise to get more eyes on this. I'm not familiar enough with ci3. |
ludamad
commented
Feb 20, 2025
| source ci3/source | ||
|
|
||
| if [ -n "${DOCKERHUB_PASSWORD:-}" ] && ([ "$REF_NAME" == "master" ] || semver check "$REF_NAME"); then | ||
| if [ -n "${DOCKERHUB_PASSWORD:-}" ]; then |
Collaborator
Author
There was a problem hiding this comment.
Can just always log-in if not external
Collaborator
Author
|
Merging as the main file here is just removal. We'll continue to iterate on the external flow in its own file. |
TomAFrench
added a commit
that referenced
this pull request
Feb 20, 2025
* master: (300 commits) fix(ci): don't have checks go green immediately (#12168) fix: ASSERTS that should throw (#12167) fix: retry rm operation in cleanup (#12162) chore: Fix linter errors (#12164) feat: Barretenberg C++ binary overhaul (#11459) fix: call install_hooks in bootstrap (#12159) chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140) test: verify proving is resumed after broker crash (#11122) chore(ci3): update ci.md with swc notes (#12147) fix: don't try to get bench artifacts on external PR (#12157) feat: partial note handling in aztec-nr (#12122) fix: external fixes pt 2 (#12153) chore: fix message path (#12150) chore(ci3): refactor ci3.yml, fix external PR flow (#12037) fix: Do not try flushing txs in bot setup if not set (#12144) chore: Silence warns on invalid bootnode enr (#12135) fix: don't early-out on test fails (#12143) feat(avm): deduplicating event emitters (#12137) chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133) test: kill prover node and see it recover (#11118) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't have overlapping check names here. We have to split this out to its own repo. This is probably a good separation of concerns, too, to prevent people just leaking secrets without stopping to think.