Skip to content

chore(ci3): refactor ci3.yml, fix external PR flow#12037

Merged
ludamad merged 34 commits intomasterfrom
ad/ci-external-fixes
Feb 20, 2025
Merged

chore(ci3): refactor ci3.yml, fix external PR flow#12037
ludamad merged 34 commits intomasterfrom
ad/ci-external-fixes

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Feb 16, 2025

  • Refactor amd64 and arm64 to be a single ci task with a matrix
  • Fix the logic around external PRs, control this with a ci-external label

@ludamad ludamad requested a review from charlielye as a code owner February 16, 2025 21:17
@ludamad ludamad marked this pull request as draft February 17, 2025 17:31
@ludamad ludamad added arm64-ci Run the ARM64 CI tests. e2e-all labels Feb 20, 2025
@ludamad ludamad marked this pull request as ready for review February 20, 2025 15:18

check_toolchains

# Ensure we have yarn set up.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled

The public inputs of public functions is defined [here](../circuits.js/src/structs/avm_circuit_public_inputs.ts).
The public inputs of public functions is defined [here](../circuits.js/src/structs/avm/avm_circuit_public_inputs.ts).

They are run with the assistance of an oracle that provides any value read from the public state tree.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled


## Releases

Releases are driven by [release-please](https://github.com/googleapis/release-please), which maintains a 'Release PR' containing an updated CHANGELOG.md since the last release. Triggering a new release is simply a case of merging this PR to master. A [github workflow](./.github/workflows/release_please.yml) will create the tagged release triggering ./bootstrap.sh release to build and deploy the version at that tag.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled

"files.insertFinalNewline": true,
"[rust]": {
"files.trimTrailingWhitespace": false
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled request from Tom

@ludamad ludamad enabled auto-merge (squash) February 20, 2025 15:32
fail-fast: false
matrix:
# Only run arm64 build with arm64-ci label.
# Thhe way to do conditions here is to parse full strings as JSON.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Thhe way to do conditions here is to parse full strings as JSON.
# The way to do conditions here is to parse full strings as JSON.

@ludamad ludamad merged commit bdef653 into master Feb 20, 2025
11 checks passed
@ludamad ludamad deleted the ad/ci-external-fixes branch February 20, 2025 15:49
TomAFrench added a commit that referenced this pull request Feb 20, 2025
* master: (300 commits)
  fix(ci): don't have checks go green immediately (#12168)
  fix: ASSERTS that should throw (#12167)
  fix: retry rm operation in cleanup (#12162)
  chore: Fix linter errors (#12164)
  feat: Barretenberg C++ binary overhaul (#11459)
  fix: call install_hooks in bootstrap (#12159)
  chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140)
  test: verify proving is resumed after broker crash (#11122)
  chore(ci3): update ci.md with swc notes (#12147)
  fix: don't try to get bench artifacts on external PR (#12157)
  feat: partial note handling in aztec-nr (#12122)
  fix: external fixes pt 2 (#12153)
  chore: fix message path (#12150)
  chore(ci3): refactor ci3.yml, fix external PR flow (#12037)
  fix: Do not try flushing txs in bot setup if not set (#12144)
  chore: Silence warns on invalid bootnode enr (#12135)
  fix: don't early-out on test fails (#12143)
  feat(avm): deduplicating event emitters (#12137)
  chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133)
  test: kill prover node and see it recover (#11118)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arm64-ci Run the ARM64 CI tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants