fix: retry rm operation in cleanup#12162
Merged
spalladino merged 1 commit intomasterfrom Feb 20, 2025
Merged
Conversation
ludamad
reviewed
Feb 20, 2025
| if (!skipCleanup) { | ||
| await fs.rm(workingDirectory, { recursive: true, force: true }); | ||
| try { | ||
| await fs.rm(workingDirectory, { recursive: true, force: true, maxRetries: 3, retryDelay: 100 }); |
Collaborator
There was a problem hiding this comment.
approving (and dequeuing) with request for log
spalladino
reviewed
Feb 20, 2025
| try { | ||
| await fs.rm(workingDirectory, { recursive: true, force: true, maxRetries: 3, retryDelay: 100 }); | ||
| } catch { | ||
| // ignore cleanup errors |
Contributor
There was a problem hiding this comment.
Why not at least log them?
Contributor
Author
There was a problem hiding this comment.
I didn't consider logging since this has only ever been seen in tests that fail.
ludamad
approved these changes
Feb 20, 2025
Contributor
|
Merging because I need this on my own PRs. Please add the logging statement later :-P |
TomAFrench
added a commit
that referenced
this pull request
Feb 20, 2025
* master: (300 commits) fix(ci): don't have checks go green immediately (#12168) fix: ASSERTS that should throw (#12167) fix: retry rm operation in cleanup (#12162) chore: Fix linter errors (#12164) feat: Barretenberg C++ binary overhaul (#11459) fix: call install_hooks in bootstrap (#12159) chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140) test: verify proving is resumed after broker crash (#11122) chore(ci3): update ci.md with swc notes (#12147) fix: don't try to get bench artifacts on external PR (#12157) feat: partial note handling in aztec-nr (#12122) fix: external fixes pt 2 (#12153) chore: fix message path (#12150) chore(ci3): refactor ci3.yml, fix external PR flow (#12037) fix: Do not try flushing txs in bot setup if not set (#12144) chore: Silence warns on invalid bootnode enr (#12135) fix: don't early-out on test fails (#12143) feat(avm): deduplicating event emitters (#12137) chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133) test: kill prover node and see it recover (#11118) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12141