Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment assignment to Big Sky before plans #99096

Merged
merged 6 commits into from
Feb 2, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 30, 2025

Related to #99011

Proposed Changes

  • We're adding the Big Sky before plans experiment
  • Replaces the feature flag with a real Explat assignment 22179-explat-experiment
  • Using the calypso_signup_onboarding_goals_first_bigsky_202501_v1 experiment
  • Stop forcing the goals-first experience in development

It implements the first branch in this flow chart

Screenshot 2025-01-30 at 1 34 31 PM

p1738272885652059/1738193377.949839-slack-C085HCWCEDN

Why are these changes being made?

wpcalypso will continue to be forced onto the goals-first experience for stakeholders. But now that we have the new experiment slugs, developers should explicitly choose the cohorts they want to test with.

Testing Instructions

  • In the Explat, configure your user to be in the treatment 22179-explat-experiment
  • Go to the /setup/onboarding and make sure you can see Big Sky
  • Finish the onboarding and make sure you're redirected to Big Sky

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 force-pushed the add/experiment-to-big-sky branch from 269cf60 to 799cabc Compare January 30, 2025 14:00
@paulopmt1 paulopmt1 marked this pull request as ready for review January 30, 2025 14:00
@paulopmt1 paulopmt1 requested a review from a team as a code owner January 30, 2025 14:00
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@paulopmt1 paulopmt1 linked an issue Jan 30, 2025 that may be closed by this pull request
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~709 bytes added 📈 [gzipped])

name               parsed_size           gzip_size
site-setup-wg           +870 B  (+0.2%)     +232 B  (+0.2%)
site-setup-flow         +870 B  (+0.2%)     +232 B  (+0.2%)
onboarding-flow         +826 B  (+0.4%)     +224 B  (+0.4%)
stepper-user-step       +823 B  (+0.3%)     +253 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 requested a review from a team January 30, 2025 17:25
@p-jackson p-jackson self-assigned this Jan 30, 2025
@p-jackson
Copy link
Member

I think we're assigning users to the experiment too soon. Checking about there here: p1738279560954329-slack-C7HH3V5AS

@p-jackson p-jackson requested review from a team and necronet and removed request for a team January 31, 2025 03:53
@p-jackson
Copy link
Member

p-jackson commented Jan 31, 2025

I think we're assigning users to the experiment too soon

The exposure event prevents bad things from happening 👍

@p-jackson p-jackson force-pushed the add/experiment-to-big-sky branch from d1e6df0 to 96fdf42 Compare January 31, 2025 08:01
Copy link

@necronet necronet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExPlat Approved

@paulopmt1 paulopmt1 force-pushed the add/experiment-to-big-sky branch from 96fdf42 to 55e9660 Compare February 1, 2025 20:43
@p-jackson p-jackson force-pushed the add/experiment-to-big-sky branch from 55e9660 to d50e234 Compare February 2, 2025 21:59
@p-jackson p-jackson merged commit 50c4358 into trunk Feb 2, 2025
13 checks passed
@p-jackson p-jackson deleted the add/experiment-to-big-sky branch February 2, 2025 22:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add experiment assignment to Big Sky into goals-first flow
4 participants