Skip to content

Commit

Permalink
Document why it's ok to ignore big-sky-before-plans loading state
Browse files Browse the repository at this point in the history
  • Loading branch information
p-jackson authored and paulopmt1 committed Feb 1, 2025
1 parent 880ed79 commit 55e9660
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const UserStepComponent: Step = function UserStep( {
const isLoggedIn = useSelector( isUserLoggedIn );
const dispatch = useDispatch();
const { handleSocialResponse, notice, accountCreateResponse } = useHandleSocialResponse( flow );
const [ , isBigSkyBeforePlansExperiment ] = useBigSkyBeforePlans();
const [ , isBigSkyBeforePlansExperiment ] = useBigSkyBeforePlans(); // If the experiment hasn't loaded yet, then it must mean we're ineligible anyway
const [ wpAccountCreateResponse, setWpAccountCreateResponse ] = useState< AccountCreateReturn >();
const { socialServiceResponse } = useSocialService();
const creatingWithBigSky = ( select( ONBOARD_STORE ) as OnboardSelect ).getCreateWithBigSky();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import './style.scss';
* The design choices step
*/
const DesignChoicesStep: Step = ( { navigation, flow, stepName } ) => {
const [ , isBigSkyBeforePlansExperiment ] = useBigSkyBeforePlans();
const [ , isBigSkyBeforePlansExperiment ] = useBigSkyBeforePlans(); // If the experiment hasn't loaded yet, then it must mean we're ineligible anyway
const isGoalsFirstVariation = isOnboardingFlow( flow ) && isBigSkyBeforePlansExperiment;

const translate = useTranslate();
Expand Down

0 comments on commit 55e9660

Please sign in to comment.