Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Sky GF: Add AI Copy to big sky plans step #99127

Merged
merged 7 commits into from
Feb 2, 2025
Merged

Conversation

vykes-mac
Copy link
Contributor

@vykes-mac vykes-mac commented Jan 30, 2025

Closes #99009

Proposed Changes

  • Add copy Unlimited AI Website Builder edits to big sky plans grid
  • Copy is rendered conditionally

image

image

Why are these changes being made?

Pre-req

  • Go to setup/onboarding goals first flow
  • Chose big sky on design choice screen
  • Continue to plans step and you should see the copy in the plans grid
  • Check the copy is also displayed on the checkout page
  • Test the copy is not shown for non goals first users

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vykes-mac vykes-mac self-assigned this Jan 30, 2025
@vykes-mac vykes-mac added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. labels Jan 30, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~340 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-main       +1250 B  (+0.1%)     +340 B  (+0.1%)
entry-login      +1190 B  (+0.1%)     +333 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6133 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
checkout                               +14344 B  (+0.8%)    +5610 B  (+1.1%)
onboarding-flow                         +1426 B  (+0.7%)     +397 B  (+0.7%)
site-setup-wg                           +1289 B  (+0.4%)     +358 B  (+0.4%)
site-setup-flow                         +1289 B  (+0.4%)     +358 B  (+0.4%)
write-flow                              +1190 B  (+0.1%)     +335 B  (+0.1%)
update-design-flow                      +1190 B  (+0.1%)     +335 B  (+0.1%)
plugin-bundle-flow                      +1190 B  (+0.2%)     +335 B  (+0.2%)
new-hosted-site-flow-user-included      +1190 B  (+0.7%)     +335 B  (+0.7%)
new-hosted-site-flow                    +1190 B  (+0.7%)     +335 B  (+0.7%)
link-in-bio-tld-flow                    +1190 B  (+0.1%)     +335 B  (+0.1%)
import-hosted-site-flow                 +1190 B  (+0.1%)     +335 B  (+0.1%)
import-flow                             +1190 B  (+0.7%)     +335 B  (+0.7%)
hundred-year-plan                       +1190 B  (+0.6%)     +335 B  (+0.6%)
hundred-year-domain                     +1190 B  (+0.5%)     +335 B  (+0.6%)
copy-site-flow                          +1190 B  (+0.1%)     +335 B  (+0.1%)
connect-domain                          +1190 B  (+0.6%)     +335 B  (+0.7%)
build-flow                              +1190 B  (+0.1%)     +335 B  (+0.1%)
stepper-user-step                        +299 B  (+0.1%)     +103 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~335 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal      +1190 B  (+0.1%)     +335 B  (+0.1%)
async-load-automattic-help-center-stepper       +1190 B  (+0.1%)     +335 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac
Copy link
Contributor Author

@p-jackson From the way the issue is worded it sounded like these copy should be rendered conditionally, is that the case?

@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • happy-blocks
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plan-step-copy on your sandbox.

@vykes-mac vykes-mac added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 30, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220117

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @vykes-mac for including a screenshot in the description! This is really helpful for our translators.

@p-jackson
Copy link
Member

@vykes-mac yeah this would be conditional on being in the onboarding flow, and have the onboarding/big-sky-before-plans feature flag (or this experiment #99096)

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, checking this now, I think these new featured features do need to be conditional.

I don't think it makes sense to display them prominently in the standard non-big-sky flow like this:

CleanShot 2025-01-31 at 20 21 32@2x

I also see they're semibold in the mockup. I'm not sure what the best way to customise this sort of thing on a per-flow basis. Especially the changes to the checkout 🤔

@vykes-mac
Copy link
Contributor Author

I also see they're semibold in the mockup. I'm not sure what the best way to customise this sort of thing on a per-flow basis. Especially the changes to the checkout 🤔

I think simplest thing right now is to add the same string twice, the bold one for the plan features and the not bold one for checkout

@vykes-mac vykes-mac requested review from a team as code owners January 31, 2025 21:28
} ),
getDescription: () => i18n.translate( 'Build your site with our AI Website Builder.' ),
},
[ FEATURE_BIG_SKY_WEBSITE_BUILDER_CHECKOUT ]: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy on the plans page should be bold, so we create a non bold one for the checkout page, maybe there is a better way to do this?

@@ -31,5 +32,7 @@ export function useGoalsFirstExperiment(): [ boolean, boolean ] {
*/
const variationName = experimentAssignment?.variationName ?? 'control';

setPlansListExperiment( EXPERIMENT_NAME, variationName );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on this #99133 PR as the experiment name is changed there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will actually go in useBigSkyBeforePlans, so it depends on #99096


export function isGoalsFirst(): boolean {
return (
getPlansListExperiment( 'calypso_signup_onboarding_goals_first_flow_holdout_20241220' ) ===
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only showing the copy to the treatment_cumulative group. @p-jackson can you confirm this? Also the experiment name when this PR is merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮
Technique makes sense! Seems like we're basically showing the new copy if the experiment assignment happens to be be loaded. If it hasn't nothing catastrophic happens, but following the usual flow the test group assignment should have been made by now.

We are only showing the copy to the treatment_cumulative group

This is one of the goals-first experiment cohorts. But this copy change shouldn't actually be part of the goals-first experiment. It's for the big sky experiment

getPlansListExperiment

I think there's actually another explat function we can use for this: dangerouslyGetMaybeLoadedExperimentAssignment

It should reach into explat and get the user's current assignment, returning null if it hasn't been assigned.

I'll make the changes so that we're using the correct experiment. Or maybe even I'll use the feature flag for this PR so I can get it merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now. getPlansListExperiment isn't a new thing we've added; it's an existing library function. If this is how previous experiments have been done, it makes sense for us to do it the same way. So I won't switch to dangerouslyGetMaybeLoadedExperimentAssignment.

@@ -80,6 +81,7 @@ export default function CheckoutMainWrapper( {
const translate = useTranslate();
const locale = useSelector( getCurrentUserLocale );
const selectedSiteId = useSelector( getSelectedSiteId ) ?? undefined;
useGoalsFirstExperiment();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to ensure the experiment assignment is stored in memory and we can retrieve it to render the feature list. But I don't love that it implicitly assigns the user to a cohort if they haven't been assigned yet.

Who knows where checkout-main-wrapper is being included from, causing an assignment to occur.

I think the hook's internal flow === 'onboarding' check will be enough to save us though.

@p-jackson p-jackson force-pushed the update/plan-step-copy branch from 4635b1d to 246305e Compare February 2, 2025 23:06
Comment on lines +10 to +12
if ( new URLSearchParams( location.search ).has( 'big-sky-checkout' ) ) {
return true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vykes-mac I added a query parameter for the checkout screen case, so that the message only appears when the user actually chooses Big Sky

Comment on lines +21 to +25
if ( typeof window === 'undefined' ) {
return false;
}

return Boolean( window.__a8cBigSkyOnboarding );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vykes-mac I discovered that the Global Styles code was doing a hack like this to conditionally show the text

export function isGlobalStylesOnPersonalEnabled(): boolean {

So I've done something similar 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this approach also, similar to global styles, but I opted for the experiment name approach so I didn't have to pass a parameter to the checkout page, but that works as well.

@p-jackson p-jackson merged commit 2c0643a into trunk Feb 2, 2025
13 checks passed
@p-jackson p-jackson deleted the update/plan-step-copy branch February 2, 2025 23:38
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Feb 2, 2025
@a8ci18n
Copy link

a8ci18n commented Feb 3, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add AI copy to the plan comparison grid when in the Big Sky plans step
4 participants