Reader: use tag.display_name to display tag names #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] Needs Review
|
Fixes #2551. |
|
|
blowery
added a commit
that referenced
this pull request
Jan 26, 2016
…ency Reader: use tag.display_name to display tag names
scruffian
removed
the
[Status] Needs Review
This was referenced Apr 19, 2016
This was referenced Apr 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2551 (comment) we decided to lowercase all tag names in the Reader.
This PR makes use of the newly-added tag
display_nameproperty (wpcom-130241) to do just that.If a tag slug is alphanumeric (dashes are also permitted), it will be used as the display name. Otherwise, the title is used. For example, the tag 未分類 uses the title rather than the slug.
Before:
After:
