Issue/3985 reader tag display name #3995
Conversation
…termines the displayed string for a tag
…ss-Android into issue/3985-reader-tag-display-name
…ss-Android into issue/3985-reader-tag-display-name
|
Hiya @nbradbury. I took the branch for a test drive. Tags appeared as expected in most cases (more on that in a bit) and I was able to preview a tag, follow a previewed tag, add a tag, and unfollow a tag. If Discover is already selected:Before installing the branch I was signed in with a self-hosted blog (no Jetpack) and Discover was the selected topic. After installing the branch Discover was still the selected topic but it would not sync any posts: Discover shows up correctly in the list After I switched to a different topic then back Discover would load correctly. wpcom missing defautsAfter signing into wpcom I went back to the reader and checked the list. The first thing that struck me as odd was a user created list was the selected topic in the list. When I opened the list, I saw that the default topics (liked, followed, Discover) were missing. My other user created list was also missing. If I refreshed the selected user created list it wouldn't load any content. However, after selecting a different topic, then selecting the user created list again, it loaded content from Discover: |
|
Retested and it looks great :) Thanks Nick. |
from me!
…ss-Android into issue/3985-reader-tag-display-name
…ss-Android into issue/3985-reader-tag-display-name Conflicts: WordPress/src/main/java/org/wordpress/android/ui/reader/services/ReaderUpdateService.java
|
@nbradbury Looks like this missed the 5.4 cutoff. Do you mind if I switch it to the 5.5 milestone? |
Not a problem - I just did that. |
…ss-Android into issue/3985-reader-tag-display-name
| + " tag_display_name TEXT COLLATE NOCASE," | ||
| + " tag_title TEXT COLLATE NOCASE," | ||
| + " tag_type INTEGER DEFAULT 0," | ||
| + " endpoint TEXT," |
There was a problem hiding this comment.
Can we fix the spacing/alignment of these two execSQL please?
There was a problem hiding this comment.
Can we fix the spacing/alignment of these two execSQL
Fixed in 09ecb34.
|
I'm seeing a lot of magic strings. While understandable in the DB functions, I believe they should be constants elsewhere. Can you make them constants please? (especially in the parsing of the JSON objects in |
In commit f95d572 I changed the JSON key names to constants in those two classes. Were there other places you think need similar changes? |
Nope, those were the only noticeable ones. Works great! |
Resolves #3985 - Changes the reader to show tags using their
display_namerather than their title. This is being done for consistency with Calypso, and the iOS app will also be making this change.This required making quite a few changes to the reader code to ensure that tags are displayed - and added - the same as they are on the web. It also required updating the list of followed tags when a new one is added, to ensure local tags are formatted the same as server.
@aerych Mind giving this a quick spin to ensure it's working correctly? I'll ask an Android dev to do a code review afterwards.