Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Topics starting with a lowercase letter should not be capitalized #2551

Closed
lancewillett opened this issue Jan 18, 2016 · 6 comments
Closed
Assignees
Labels
[Feature] Reader The reader site on Calypso. [Type] Bug

Comments

@lancewillett
Copy link
Contributor

Raised by @aerych

Topics like iPhone, iOS, ePaper are showing up with the first character capitalized. This looks like an API issue as the behavior is being reproduced in the iOS and Android apps where it previously wasn't.

Examples:
screen shot 2015-09-09 at 7 54 22 pm
screen shot 2015-09-09 at 7 54 26 pm
screen shot 2015-09-09 at 7 54 51 pm
screen shot 2015-09-09 at 7 55 01 pm
screen shot 2015-09-09 at 7 55 12 pm
screen shot 2015-09-09 at 7 55 20 pm

@lancewillett lancewillett added [Type] Bug [Feature] Reader The reader site on Calypso. labels Jan 18, 2016
@lancewillett lancewillett added this to the Reader: List Management milestone Jan 18, 2016
@lancewillett
Copy link
Contributor Author

Confirmed, testing in Safari 8.0.8 on OS X 10.10.5.

Steps to repeat:

  1. Log in to wcalypso, Reader tab
  2. In left-hand sidebar, find Tags and enter "ePaper" or "iOS" into the "Follow a Tag" input field.
  3. Click the plus icon or hit Enter on keyboard to add the tag.
  4. Notice the tag title gets rename: "EPaper" and "IOS" with first letter capitalized.

Further note: in the display title for the tag archive (stream-header__title) the spelling is also different, not consistent with the tag title in the sidebar or the original input.

Original input: iOS
Tag sidebar title: IOS
stream-header__title: Ios

@lancewillett
Copy link
Contributor Author

See also #1546

@blowery
Copy link
Contributor

blowery commented Jan 18, 2016

hrm. half thinking we just lowercase everything, all the time. there's no way to get this right and have it automated.

@blowery blowery changed the title Reader: nopics starting with a lowercase letter should not be capitalized Reader: Topics starting with a lowercase letter should not be capitalized Jan 18, 2016
@bluefuton
Copy link
Contributor

just lowercase everything, all the time. there's no way to get this right and have it automated.

+1. That's how a lot of other sites handle tags.

If we do that, do we want to make the change on the API level, or on each individual UI?

@blowery
Copy link
Contributor

blowery commented Jan 21, 2016

If we do that, do we want to make the change on the API level, or on each individual UI?

API level would be best.

@bluefuton
Copy link
Contributor

Fixed in #2775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants