Me: Use SitesDropdown instead of SelectSite in /me/account

[ebinnion]

Fixes #451

Now that we have a SitesDropdown, we can retire our use of SelectSite. This component swaps out the former for the latter on the /me/account route.

Note: There is still some jankiness where switching a site and then refreshing the page may not show the proper primary site. This is because the sites list data is stale after we make the change. So, we'll need to find some way to update the primary site in the sites list.

To test:

• Checkout fix/me-account-site-dropdown
• Go to /me/account
• Change primary site
• Go to wordpress.com/me/account
• Does primary site reflect the change that you just made?

[ockham]

Now that #1886 has been merged, this is the last occurrence of me/select-site.jsx, so maybe you could also remove that file as part of this PR?

[mtias]

Nice.

This is because the sites list data is stale after we make the change. So, we'll need to find some way to update the primary site in the sites list.

This is something we'll properly fix once we migrate site-settings to redux and centralize the data. In the meantime you could just set the primary attribute manually, or change the order of the array. This is where we set the attribute.

cc @rralian to keep in mind for settings.

[ebinnion]

@mtias - I updated the PR to manually set the primary site. After I did that, I noticed that the old primary site still showed on refresh, which I tracked down to SitesDropdown falling back to the primary site if a site is not specified. So, the primary site was being shown until the /me/settings API call came back.

I addressed by adding an isPlaceholder prop to SitesDropdown which, when true, will display a Site placeholder.

After that, I noticed that the site and chevron could overlap each other. So, I adjusted the styling of the component to use flexbox.

Overlapping:

Overlapping fixed:

Chrome:

IE11:

iPhone4

Safari:

@ockham - I went ahead and removed the select-site component in this PR as well. 👍

[rickybanister]

Looks good to me.

[dmsnell]

is this a typo? should it be:

if ( selectedSite ) {

[ebinnion]

heh... you're right 😄 I created the variable so I didn't have to get the site twice, and then I did it anyways 🐼

[dmsnell]

@ebinnion looks good. My only real question was about a possible typo and the data path for updating the primary site.