Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiteSelectorModal: SitesDropdown extends below the bottom of the browser #1886

Closed
ockham opened this issue Dec 21, 2015 · 2 comments
Closed

SiteSelectorModal: SitesDropdown extends below the bottom of the browser #1886

ockham opened this issue Dec 21, 2015 · 2 comments
Labels
Components [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Stale [Type] Bug
Milestone
Themes: Maintenance

Comments

@ockham
Copy link
Contributor

ockham commented Dec 21, 2015

From #1483 (comment):

screen shot 2015-12-17 at 16 29 45

The dropdown is extending beyond the bottom of the browser on my 13" MBP.

From #1483 (comment):

I think the true solution to this is to be able to specify the position of the dropdown site-selector—for example drop up or centered. I believe there is a v1.1 design that has it vertically centred, so maybe we go with what we have for now and iterate.

(See #451 for that v1.1 design.)
@ockham ockham added [Type] Bug [Feature Group] Appearance & Themes Features related to the appearance of sites. Components labels Dec 21, 2015
@ockham ockham mentioned this issue Dec 21, 2015
Merged
@folletto folletto added this to the Themes: Maintenance milestone Jan 21, 2016
@ockham ockham mentioned this issue Jun 3, 2016
Closed
@seear
Copy link
Contributor

seear commented Jun 13, 2016

A quick fix might be to use component-tip (we use this for popovers) which will pop up wherever there is most space.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Stale [Type] Bug
Projects
None yet
Milestone
Themes: Maintenance
Development

No branches or pull requests
3 participants
@folletto @ockham @seear