Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me / Site Picker: suggestion: use blog picker styles for primary blog dropdown #451

Closed
alisterscott opened this issue Nov 22, 2015 · 5 comments · Fixed by #1837
Closed
Assignees
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Site Picker [Type] Enhancement

Comments

@alisterscott
Copy link
Contributor

Originally raised by @jkudish: it would be nice if the "primary blog" dropdown was similar in functionality to the main blog picker in calypso to allow easier selection of the blog to use.

Feedback from @mtias

Agreed, whenever we show Sites we should use <Site /> to render them. It would even make sense to put a list of <Site>s within <DropdownSelect />.

Design feedback from @folletto

For reference, here's the mockup of the component for both v1.0 and v1.1:

sitepicker1

sitepicker2

@alisterscott alisterscott added [Type] Enhancement Site Picker [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. labels Nov 22, 2015
@mtias
Copy link
Member

mtias commented Nov 22, 2015

Being worked on in #379.

@v18
Copy link
Contributor

v18 commented Nov 29, 2015

@mtias: Dropping a note here that came out of a related discussion: we should also update the site picker to only show visible sites (as set in wp-content > My Blogs). Calypso already shows only visible sites in the sidebar site picker.

@mtias
Copy link
Member

mtias commented Nov 29, 2015

@v18 yes, this component is based on SitesSelector which is the shared component between the sidebar picker, and the new-post popover, which handles showing visible sites only (until you search), etc. It's one of the main reasons why all of our "site selection" UI pieces should be using this core component :)

@v18
Copy link
Contributor

v18 commented Nov 30, 2015

Thanks for the info! That's fantastic :)

@rickybanister
Copy link

@ebinnion does this seem like something easy enough to slot in for our clean up time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Site Picker [Type] Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants