Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Fallback to URL if site title empty #1529

Closed
jeremeylduvall opened this issue Dec 12, 2015 · 2 comments · Fixed by #1589
Closed

Help: Fallback to URL if site title empty #1529

jeremeylduvall opened this issue Dec 12, 2015 · 2 comments · Fixed by #1589
Assignees
Labels
[Feature Group] Support All things related to WordPress.com customer support. [Pri] High [Type] Bug
Milestone

Comments

@jeremeylduvall
Copy link
Contributor

If the site title is empty, the dropdown under "Which site do you need help with?" is blank (the top line in the dropdown is a site):

screen shot 2015-12-11 at 7 31 27 pm

We should fallback to a site URL here just in the chance that the title field is blank.

@jeremeylduvall jeremeylduvall added [Type] Bug Live Chat [Feature Group] Support All things related to WordPress.com customer support. labels Dec 12, 2015
@dllh dllh added this to the Help: v1 milestone Dec 14, 2015
@mtias
Copy link
Member

mtias commented Dec 14, 2015

This should be replaced with SitesDropdown which is now merged. See #451.

@omarjackman
Copy link
Contributor

This should be replaced with SitesDropdown which is now merged. See #451.

@mtias I created #1588 to use the SitesDropdown component but there is a visual issue that needs to be fixed before it can be completed. The last item in the list gets cut off. See:
screen shot 2015-12-14 at 11 39 46 pm

In the meantime I will just do the quick fix for the issue described here and put it in another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Support All things related to WordPress.com customer support. [Pri] High [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants