Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Migrate tests from Makefile to single test runner #3942

Closed
gziolo opened this issue Mar 10, 2016 · 11 comments · Fixed by #4294
Closed

Framework: Migrate tests from Makefile to single test runner #3942

gziolo opened this issue Mar 10, 2016 · 11 comments · Fixed by #4294
Assignees
@gziolo
Labels
Framework [Type] Task
Milestone
Framework: Single...

Comments

@gziolo
Copy link
Member

gziolo commented Mar 10, 2016 •
edited by p3ob7o
Loading

Part of #3822.

Makefile list

The following list contains all Makefiles we had when we started migration process:

Please assign yourself to the list when you start working on removing Makefile in favor of single test runner.

√ - it means test suite can be executed independently from other suites using npm run test-client path/to/test/file-name.js
x - it means test suite depends on other suite - we should fix that at some point
@gziolo gziolo self-assigned this Mar 10, 2016
@gziolo gziolo added this to the Framework: Single test runner milestone Mar 10, 2016
This was referenced Mar 10, 2016
Closed
Merged
Merged
Merged
@gziolo
Copy link
Member Author

gziolo commented Mar 16, 2016

@mtias can you help us find more devs to speed up migration process? :)

@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

I assigned myself a handful more tests, which I'll plan to start migrating today.

@gziolo
Copy link
Member Author

gziolo commented Mar 16, 2016

@aduth: Awesome, feel free to ping me for a review ;)

I noticed that also @umurkontaci is assigned to some tests, same rule applies of course :D

@aduth aduth mentioned this issue Mar 16, 2016
Merged
@umurkontaci
Copy link
Contributor

I have tried client/auth, components/count and components/forms/form-phone-input but they all failed with one way or the other.

@blowery @aduth @gziolo Is there a known way to fix them?

One thing I've encountered was I think we were cleaning up DOM but the components were still trying access window. Some async weirdness.

The other was: this.translate or any this.numberFormat was undefined, I think this was due to this being the wrong context, not just mixins being skipped.

@gziolo
Copy link
Member Author

gziolo commented Mar 18, 2016

@umurkontaci Thanks for working on that. I marked them on the list and I would skip them now, and get back to them once we migrate easier bits :)

@seear seear mentioned this issue Mar 18, 2016
Merged
@dmsnell dmsnell mentioned this issue Mar 23, 2016
Merged
@dmsnell dmsnell mentioned this issue Mar 24, 2016
Merged
dmsnell added a commit that referenced this issue Mar 24, 2016
@dmsnell
Update Interval tests to run in single-runner
0a944e2 
See #3942

This patch removes the `Makefile` from the `<Interval />` test suite and
adds the tests into the single-test-runner white-list. It updates the
tests to conform to the new specs, using `useFakeDom()` instead of the
older initialization code.

**Testing**

From the project root run `make test`
dmsnell added a commit that referenced this issue Mar 24, 2016
@dmsnell
Update importer tests to run in single-runner
4a17e92 
See #3942

This patch removes the Makefile from the ithe importer test suite and
adds the tests into the single-test-runner white-list. No changes to the
tests themselves were needed.

**Testing**

From the project root run make test

cc: @blowery
blowery pushed a commit that referenced this issue Mar 24, 2016
@dmsnell @blowery
Update importer tests to run in single-runner
7645ef3 
See #3942

This patch removes the Makefile from the ithe importer test suite and
adds the tests into the single-test-runner white-list. No changes to the
tests themselves were needed.

**Testing**

From the project root run make test

cc: @blowery
@stephanethomas stephanethomas mentioned this issue Mar 24, 2016
Merged
@stephanethomas stephanethomas mentioned this issue Mar 24, 2016
Merged
@stephanethomas stephanethomas self-assigned this Mar 24, 2016
@blowery blowery reopened this Mar 25, 2016
@blowery
Copy link
Contributor

blowery commented Mar 25, 2016

Gotta be careful with those commit messages. 😄

This was referenced Apr 5, 2016
Merged
Merged
@jhnstn jhnstn mentioned this issue Apr 5, 2016
Merged
@gziolo gziolo mentioned this issue Apr 6, 2016
Merged
This was referenced Apr 6, 2016
Merged
Merged
This was referenced Apr 7, 2016
Merged
Merged
Merged
@aduth aduth mentioned this issue Apr 8, 2016
Merged
@jhnstn jhnstn mentioned this issue Apr 8, 2016
Merged
4 tasks
@gziolo gziolo mentioned this issue Apr 13, 2016
Merged
@aduth aduth mentioned this issue Apr 13, 2016
Merged
@gziolo gziolo mentioned this issue Apr 18, 2016
Merged
This was referenced Apr 19, 2016
Merged
Merged
Merged
Merged
Merged
@gziolo
Copy link
Member Author

gziolo commented Apr 20, 2016

@umurkontaci Do you plan to work on removing client/auth/Makefile this week or should someone else take care of it?

This was referenced Apr 20, 2016
Merged
Merged
@gziolo
Copy link
Member Author

gziolo commented Apr 20, 2016

@umurkontaci Do you plan to work on removing client/auth/Makefile this week or should someone else take care of it?

Forget it, I was able to move it myself, you can help with review :)

@gziolo
Copy link
Member Author

gziolo commented Apr 20, 2016

Done 🎆

@gziolo gziolo closed this as completed Apr 20, 2016
@jhnstn jhnstn mentioned this issue Apr 20, 2016
Merged
@aduth
Copy link
Contributor

aduth commented Apr 20, 2016 •
edited
Loading

Woohoo! 🎉 But to avoid premature celebration, there's still three remaining Makefiles that I believe should be removed:

The first looks to have been migrated already, and should probably be simply deleted. The other two require migration, but appear to be fairly simple.

@gziolo
Copy link
Member Author

gziolo commented Apr 20, 2016

@aduth: 2 of them are removed with #4596 :)
I missed lowercase :D

@gziolo gziolo mentioned this issue Apr 21, 2016
Merged
6 tasks
@aduth aduth mentioned this issue Apr 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
Framework [Type] Task
Projects
None yet
Milestone
Framework: Single test runner
Development

Successfully merging a pull request may close this issue.

Tests: Move Features List tests to single test runner Automattic/wp-calypso
5 participants
@blowery @stephanethomas @gziolo @umurkontaci @aduth