Framework: Switch menus tests to single runner #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for the single runner.
| useSandbox(); | ||
|
|
||
| const menuDataPath = path.dirname( require.resolve( 'lib/menu-data' ) ); | ||
| useFilesystemMocks( menuDataPath + '/test' ); |
There was a problem hiding this comment.
Technique here for picking up filesystem mocks from elsewhere is convoluted, so maybe we can add something into the helper for this if it becomes common.
There was a problem hiding this comment.
i think this is actually OK. I like that it requires a bit of gymnastics to do something odd.
seear
added
[Status] Needs Review
|
looks good! 🚢 |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
I added one tiny change. We started to name all test files after file under test. We already have |
gziolo
added a commit
that referenced
this pull request
Mar 22, 2016
Framework: Switch menus tests to single runner
|
Thanks @gziolo I missed that. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This went mostly smoothly. Had to introduce the use of filesystem mocks into the
item-optionstest to avoiddouble callback!hangs.