Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: port lib/user tests to single runner #4609

Merged
merged 5 commits into from
Apr 18, 2016
Merged

Tests: port lib/user tests to single runner #4609

merged 5 commits into from
Apr 18, 2016

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Apr 8, 2016 •
edited
Loading

part of #3942

port the following tests to a single runner

  • /lib/user/
  • /lib/user-settings/
  • /lib/users/
  • /lib/viewers/

cc @gziolo @blowery @aduth

Testing
all tests work in isolation
npm run test-client

npm run test-client client/lib/user/test/utils.js -- -w
npm run test-client client/lib/user-settings/test/index.js -- -w
npm run test-client client/lib/users/test/store.js -- -w
npm run test-client client/lib/viewers/test/store.js -- -w

@jhnstn jhnstn force-pushed the update/port-lib-tests branch 5 times, most recently from 4dd088b to 697bd61 Compare April 15, 2016 18:53
@jhnstn jhnstn added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress and removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 15, 2016
@jhnstn jhnstn force-pushed the update/port-lib-tests branch 2 times, most recently from 2eaa9c4 to 2851821 Compare April 15, 2016 19:41
@blowery
Copy link
Contributor

blowery commented Apr 15, 2016 •
edited
Loading

Just need to nuke the makefile in lib/viewers @jhnstn and it should be good?

@jhnstn jhnstn force-pushed the update/port-lib-tests branch from 2851821 to bf6c217 Compare April 15, 2016 20:19
@jhnstn jhnstn added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 15, 2016
Jason Johnston added 4 commits April 15, 2016 14:08
Tests: port lib/user tests to single runner
95fae6b
Tests: port user settings test to single runner
ceb0425 
update test doubles

refactor test

register test with runner
Tests: port lib/users to single test runner
98b2df8 
update test doubles

register test with runner

refactor store test
Tests: port lib/viewers to single runner
e6449a6 
update test doubles

register test with runner

refactor store test
@jhnstn jhnstn force-pushed the update/port-lib-tests branch from bf6c217 to e6449a6 Compare April 15, 2016 21:08
@gziolo gziolo added this to the Framework: Single test runner milestone Apr 16, 2016
@gziolo gziolo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 16, 2016
@gziolo
Copy link
Member

gziolo commented Apr 16, 2016

Works as expected. Makefile already removed, so should be good to 🚢

@gziolo gziolo mentioned this pull request Apr 16, 2016
Closed
@gziolo gziolo merged commit 754e4cc into master Apr 18, 2016
@gziolo gziolo deleted the update/port-lib-tests branch April 18, 2016 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhnstn jhnstn

Labels
Framework OSS Citizen
Projects
None yet
Milestone
Framework: Single test runner
Development

Successfully merging this pull request may close these issues.
5 participants
@jhnstn @blowery @gziolo @lancewillett @matticbot