BCB + children: use nav block responsive control #3870
Conversation
|
This is ready for evaluation (though you'll have to merge two branches into a local Gutenberg instance to evaluate currently) but isn't ready to bring in until those (or at least one of the items) lands. I would appreciate some eyes on the change though. |
pbking
force-pushed
the
refactor/responsive-nav
branch
from
547e7fe
to
834716c
Compare
|
I get some weirdness when I try to close the menu, but it might just be trying to test this in a browser rather than actually on mobile:
In any case, if it is an issue it should be reported / worked on in the nav block. Other than that and my other comment about the template parts, this PR LGTM. We can address Quadrat mobile styling in a separate PR. |
Already reported and noted in the description. |
|
Moved the nav stuff from BCB into Quadrat as backup. This is ready for another look-see. Suggest any further theme-specific mobile-only changes happen in followups. |
|
Tested and verified that Quadrat's mobile menu is working as it was before this PR. Sadly I can't give the official green check since I opened the PR. But here it is in spirit ✅ |
|
Hah, well I can so I think with our powers combined we squash and merge this thing! |
Changes proposed in this Pull Request:
This change is needed so that the navigation block can be configured to support responsive mobile stylings.
A fix for this issue is necessary to get mobile navigation stylings to work as expected. (fix here) (fixed)
With BOTH of those fixes in place these changes work to style the navigation block's mobile styling. This change shouldn't come in until fix #31917 has landed. Quadrat will not work as expected until #31917 lands.
NOTE: This bug was found and logged while working on this. It's irritating but not a blocker to bring this change in.
In addition to the above this work this change:
Related issue(s):
Screenshots
BCB:
Seedlet-Blocks:
Mayland-Blocks:
Quadrat:
(known issue)