Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Mobile Navigation Close Button triggers actions behind it #31957

Closed
pbking opened this issue May 18, 2021 · 5 comments · Fixed by #36837
Closed

Clicking Mobile Navigation Close Button triggers actions behind it #31957

pbking opened this issue May 18, 2021 · 5 comments · Fixed by #36837
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@pbking
Copy link
Contributor

pbking commented May 18, 2021

Description

When clicking on the CLOSE button for the mobile navigation block with the wp admin bar showing the "admin profile" is triggered as well as the close action.

Step-by-step reproduction instructions

  • Setup a navigation block with responsive controls.
  • Go to the view and open the menu
  • Close the menu
  • Note that in addition to the menu closing the user has navigated to the admin profile page. (See reproduction)

NOTE: In the recording it looks like multiple clicks trigger the behavior, but I promise there was only one...

Screenshots or screen recording (optional)

Screen Capture on 2021-05-18 at 16-32-24

WordPress information

  • WordPress version: latest (wp-env)
  • Gutenberg version: trunk
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No
@vcanales
Copy link
Member

Hello! Progress on this is being tracked in #31765

@pbking
Copy link
Contributor Author

pbking commented May 19, 2021

Hrm. I'm not sure I see how it's related but I'll keep my eye on that one. Thank you.

@talldan talldan added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Jun 9, 2021
@vcanales
Copy link
Member

vcanales commented Sep 3, 2021

@pbking Could you confirm if this is still an issue. Testing manually, it looks like it's been fixed.

Kapture 2021-09-03 at 16 12 51

@carolinan
Copy link
Contributor

carolinan commented Oct 6, 2021

Chrome and Firefox:
I am only able to reproduce this in a way that the profile/logout submenu is shown (because it shows on hover), it doesn't take me all the way to the user profile page.

In Opera, the submenu does not open when the navigation block is closed.

Should also test what happens on mobile (double tap?)

@pbking
Copy link
Contributor Author

pbking commented Oct 13, 2021

I can confirm that this continues to happen in Chrome when using the developer tools to simulate a mobile experience. I have not experienced this on an actual mobile device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants