Style Seedlet mobile navigation #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
commented
May 21, 2021
| .wp-block-navigation-link { | ||
| //NOTE: For reasons I cannot explain... if I set this to use the --wp--preset--font-family--headings | ||
| //these values (which are what are set) are not respected in the modal. | ||
| font-family: var(--font-headings, 'Playfair Display', Georgia, Times, serif); |
There was a problem hiding this comment.
This is strange and I don't understand why this is. Perhaps somebody could help me figure out why using the variable in this space wasn't working...
font-family: var(--wp--preset--font-family--headings);
There was a problem hiding this comment.
Odd bug - I think it's safe to add font-family: var(--wp--preset--font-family--headings);
It works fine for me:
pbking
force-pushed
the
style/seedlet-blocks-mobile-navigation
branch
from
b78a90e
to
1acdfc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This follows up on #3870 and styles the Navigation Block's mobile menu.
Turns out there's no need for breakpoints after all...
Before:
After:
Design Target:
