feat(prompts)!: prompt template management #5724
Merged
+52,065
−6,415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mikeldking
added
the
feature branch
RogerHYang
requested changes
Dec 12, 2024
mikeldking
force-pushed
the
prompts
branch
4 times, most recently
from
6da6bdc to
3c3c5e0
Compare
mikeldking
force-pushed
the
prompts
branch
2 times, most recently
from
b34c106 to
4973813
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
commit: |
mikeldking
changed the title
* wip * WIP * WIP * add the prompt type * add initial listing * feat: temporary prompt * final changes * add aria role
…rompt specific playground (#5748) * feat(prompts): Add prompt selection combobox to playground instances * Implement prompt/:id/playground route and add link from prompt page * Rename prompt combobox components for clarity
* feat(prompts): Implement SavePromptForm for creating new prompts * Rename button to 'save'
* Add prompt table migrations * Fix typo * Update migration test * Address migration feedback * Use default names for constraints * Add source prompt id
* Add PromptVersion query * Update src/phoenix/server/api/types/PromptVersion.py * reorganize * cleanup * Update the schema --------- Co-authored-by: Mikyo King <mikyo@arize.com>
* refactor(prompts): URL based routing and loader sharing for prompts - /prompts/:prompId has been converted to a layout component - sub-routes of promptId share loader data with promptLoader - prompt detail page tabs perform navigations * feat(prompts): Add query fragment to prompt versions sub-route * feat(prompts): Implement routing, loaders, and fragments for prompt version list * Add PromptVersion to node query * fix imports * Ensure all unset fields are set * fix comma * Distinguish prompt version details from one another * Move truncate component * Consolidate prompt tab nav logic --------- Co-authored-by: Dustin Ngo <dustin@arize.com>
…5780) * feat(prompts): Render model invocation params in propt details view * Use fragment in PromptInvocationParameters * temporarily use component styles for lists until we can migrate * fix scrolling --------- Co-authored-by: Mikyo King <mikyo@arize.com>
* feat(prompts): Render prompt messages on prompt detail view * Remove unused import * Implement copy and paste button on prompt chat messages * Render chat messages on prompt version details page * Redirect to latest version when clicking versions tab Additionally highlight active version in versions list * Update example data to match template language * Fix prompt details page width, prompt versions borders / scroll * Distinguish readOnly TemplateEditor styling from normal TemplateEditor * Refactor active prompt id into prop * Replace custom button with styled anchor * Rename node in promptVersion query
* Flesh out PromptVersionTemplate type * Return GraphQL objects with the correct type * Use new types in node query * Decouple pydantic models and gql types * Rebuild gql schema * Rework model names * Update gql schema * Propagate name into schema * Incorporate feedback * Update schema * adjust UI to new schema * cleanup * Remove `hub` naming and clean up type annotations --------- Co-authored-by: Mikyo King <mikyo@arize.com>
* refactor(prompts): unify template format * migrate the frontend * build openapi * refactor python client * refactor JS * fix db * run ruff * fix tests * cleanup * more cleanup * run ci on prompts * ruff again * more fixes to python tests * restore PromptTemplateFormat * ruff * build openapi * build client * cleanup * fix tests * cleanup
* feat(prompts): initial prompt creation * add create function * export function * add test * add convenience method * cleanup * fix bug * fix bug * switch input to be camel case * add to readme * add changeset * actually use the client in the example * Update js/packages/phoenix-client/README.md
* cleanup * cleanup * cleanup * cleanup * cleanup * cleanup
* fix(prompts): Parse tool result json correctly Co-authored-by: Mikyo King <mikyo@arize.com>
* Tweak descriptions * Remove needless import * ruff * fix tests --------- Co-authored-by: Mikyo King <mikyo@arize.com>
* rename google provider * test prompts * update the rest of python code * update frontend * fix client * typescript client * Tweak empty state for invocation params --------- Co-authored-by: Tony Powell <apowell@arize.com>
dosubot
bot
added
size:XXL
axiomofjoy
approved these changes
Feb 19, 2025
RogerHYang
approved these changes
Feb 19, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5582