Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prompts): add code snippets using the phoenix-clients #6441

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

mikeldking
Copy link
Contributor

Screenshot 2025-02-18 at 3 21 57 PM Screenshot 2025-02-18 at 3 21 34 PM

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 18, 2025
const config = languageConfigs.python.openai;
return config.clientTemplate({
tab: TAB,
verionId: prompt.versionId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be called versionId across the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need cspell ;)

prompt,
sdk: "anthropic",
variables: {
key: "value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a single line comment explaining what this is

@mikeldking mikeldking merged commit 1f867a3 into prompts Feb 19, 2025
10 checks passed
@mikeldking mikeldking deleted the mikeldking/client-code branch February 19, 2025 00:09
mikeldking added a commit that referenced this pull request Feb 19, 2025
* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup
s-yeddula pushed a commit that referenced this pull request Mar 5, 2025
* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants