refactor(prompts): unify template format and language #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
commit: |
axiomofjoy
reviewed
Feb 16, 2025
| @@ -48,9 +48,9 @@ class PromptMessageRole(str, Enum): | |||
| TOOL = "TOOL" | |||
|
|
|||
|
|
|||
| class PromptTemplateFormat(str, Enum): | |||
| class TemplateFormat(str, Enum): | |||
There was a problem hiding this comment.
Maybe we can keep as PromptTemplateFormat for the sake of consistency with the other types in this file. Or remove the Prompt prefix from the other types.
axiomofjoy
approved these changes
Feb 16, 2025
mikeldking
added a commit
that referenced
this pull request
Feb 19, 2025
* refactor(prompts): unify template format * migrate the frontend * build openapi * refactor python client * refactor JS * fix db * run ruff * fix tests * cleanup * more cleanup * run ci on prompts * ruff again * more fixes to python tests * restore PromptTemplateFormat * ruff * build openapi * build client * cleanup * fix tests * cleanup
s-yeddula
pushed a commit
that referenced
this pull request
Mar 5, 2025
* refactor(prompts): unify template format * migrate the frontend * build openapi * refactor python client * refactor JS * fix db * run ruff * fix tests * cleanup * more cleanup * run ci on prompts * ruff again * more fixes to python tests * restore PromptTemplateFormat * ruff * build openapi * build client * cleanup * fix tests * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6402
removes a couple hundred lines of un-necessary duplication