Skip to content

fix(i18n): localize Mémo Back taxonomy labels EN/RU/PT (#443 follow-up) - #446

Merged
jsboige merged 1 commit into
masterfrom
fix/memo-back-taxonomy-i18n-443
Jun 6, 2026
Merged

fix(i18n): localize Mémo Back taxonomy labels EN/RU/PT (#443 follow-up)#446
jsboige merged 1 commit into
masterfrom
fix/memo-back-taxonomy-i18n-443

Conversation

@jsboige

@jsboige jsboige commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Problème

La carte Mémo Back affichait encore sa taxonomie (Famille / Sous-Famille / Soussousfamille) en français dans les langues EN/RU/PT, alors que la Face était bien localisée.

Cause : au runtime, le dos est rendu via BackFieldConversions (CardSetLocalization.TranslateCardSetInfo, front:false), or les BackFieldConversions du Mémo ne contenaient que tagline_fr. Seuls le sous-titre (via StaticConversions, #358) et la Face (via FrontFieldConversions) étaient traduits. Résidu non couvert par #443 (81af2279).

Correctif

Ajout de Soussousfamille / Sous-Famille / Famille → colonnes Family* aux BackFieldConversions du Mémo, du plus spécifique au moins spécifique pour que Famille}} ne vienne pas écraser Sous-Famille}}.

Sûr pour le sélecteur de famille FR-invariant : FormatField ajoute }} sans espace, donc il matche les tokens d'affichage {{Famille}} mais pas l'opérande ifCond Famille "==" (espace avant ==) ni {{Famille_camelCase}} (classe CSS couleur). Le regroupement 8/8 familles, piloté par les données (Famille FR == text_fr FR), reste intact.

Tests

FallaciesLocalizationTests — nouvelle couverture appliquant BackFieldConversions (pas Front) au vrai template Argumentum_Memo_Back_fr.json pour EN/RU/PT :

  • les tokens taxonomie se localisent ({{Family}}, {{Subfamily}}, {{Subsubfamily}} + variantes _ru/_pt) ;
  • les tokens FR d'affichage disparaissent ;
  • le sélecteur de regroupement reste FR (Famille "==", text_fr) ;
  • la classe CSS {{Famille_camelCase}} est préservée ;
  • le sous-titre reste localisé via StaticConversions.
    • test de forme/ordre de la config.

Suite complète : 155 pass / 0 fail / 5 skip.

Validation visuelle

⚠️ Régénération Mémo Back EN/RU/PT requise après merge (po-2023) → re-validation visuelle ai-01 (Playwright + vision) avant présentation #140/#134 à jsboige. #435 reste OUVERTE jusqu'à cette re-validation.

Refs #358 #435 #443

🤖 Generated with Claude Code

The Mémo Back card kept its taxonomy labels (Famille / Sous-Famille /
Soussousfamille) in French for EN/RU/PT because the Memo
BackFieldConversions only carried tagline_fr. At runtime the Back is
rendered through BackFieldConversions (TranslateCardSetInfo, front:false),
so its taxonomy display tokens were never localized — only the subtitle
(via StaticConversions) and the Face (via FrontFieldConversions) were.

Add Soussousfamille/Sous-Famille/Famille → Family columns to the Memo
BackFieldConversions, most-specific-first so "Famille}}" cannot clobber
"Sous-Famille}}". Safe for the FR-invariant ifCond family selector:
FormatField appends "}}" with NO space, so it matches the {{Famille}}
display tokens but not the `Famille "=="` operand nor {{Famille_camelCase}}
CSS class — the data-driven 8/8 family grouping stays untouched.

Adds FallaciesLocalizationTests regression coverage that applies
BackFieldConversions (not Front) to the real Memo Back template for
EN/RU/PT, asserting taxonomy tokens localize while the grouping selector
stays FR, plus a config-shape ordering test. Full suite: 155 pass / 0 fail.

Refs #358 #435 #443

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jsboige
jsboige merged commit 2169d7b into master Jun 6, 2026
3 checks passed
@jsboige
jsboige deleted the fix/memo-back-taxonomy-i18n-443 branch June 6, 2026 23:58
jsboige added a commit that referenced this pull request Jun 7, 2026
…p) (#446)

The Mémo Back card kept its taxonomy labels (Famille / Sous-Famille /
Soussousfamille) in French for EN/RU/PT because the Memo
BackFieldConversions only carried tagline_fr. At runtime the Back is
rendered through BackFieldConversions (TranslateCardSetInfo, front:false),
so its taxonomy display tokens were never localized — only the subtitle
(via StaticConversions) and the Face (via FrontFieldConversions) were.

Add Soussousfamille/Sous-Famille/Famille → Family columns to the Memo
BackFieldConversions, most-specific-first so "Famille}}" cannot clobber
"Sous-Famille}}". Safe for the FR-invariant ifCond family selector:
FormatField appends "}}" with NO space, so it matches the {{Famille}}
display tokens but not the `Famille "=="` operand nor {{Famille_camelCase}}
CSS class — the data-driven 8/8 family grouping stays untouched.

Adds FallaciesLocalizationTests regression coverage that applies
BackFieldConversions (not Front) to the real Memo Back template for
EN/RU/PT, asserting taxonomy tokens localize while the grouping selector
stays FR, plus a config-shape ordering test. Full suite: 155 pass / 0 fail.

Refs #358 #435 #443

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
jsboige added a commit that referenced this pull request Jun 8, 2026
)

Harvests were stale from pre-#446 build. Clobbered + rebuilt + re-harvested.
All 8 languages: FR/EN/RU/PT/AR/ES/FA/ZH

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsboige added a commit that referenced this pull request Jun 8, 2026
…le caveat (#448)

§2ter updated to reflect that #438/#439/#443/#446 are now MERGED on master
(dc01445), not on feature branches. Records the 2026-06-08 full-regen Debug
validation: 6/6 CardSets PASS, Mémo Back localized 8/8 (incl. AR/ES/FA/ZH = no
CSV gap), confirming #446 on the merged deliverable.

Adds a verified caveat: the local Release build (2026-06-02) predates #443/#446,
so its Mémo Back is stale FR (native crop confirms FR subtitle + FR taxonomy).
The final -c Release regen must be re-run on dc01445 with explicit Memo harvest
clobber before any sign-off/tag. §1 build-selection note flagged accordingly.

Refs #140 #134 #443 #446

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
jsboige added a commit that referenced this pull request Jun 15, 2026
…α resubmit) (#484)

Re-submit the α deliverable from #444 (closed stale) as a clean doc-only PR.
The original #444 bundled α (this assessment) + β (Memo Back loc fix = #446)
+ γ (gpt-5.5 PT task = #447). β and γ are already on master; γ additionally
carried a parasite gpt-5.5→5.4-mini downgrade on 12 sites (avoided). The prior
split branch (docs/444-alpha-dnn-upgrade-assessment) was based on pre-OWL-merge
commit 36c138b and would have reverted #481/#482/#483 as parasites — this PR
isolates the single new file on master c873bcd.

Related: #131 (DNN security/upgrade), #132 (DNN deployment), #134 (release v0.9.0).
Supersedes: #444 (closed stale; β=#446, γ=#447 already merged).

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant