feat(dataset-updater): Fallacies PT register polish task (#411) - #447
Merged
Merged
Conversation
Add DatasetUpdater config for Fallacies taxonomy PT register harmonization. Matches existing Virtues/Scenarii PT register task pattern: - Fields: text_pt, desc_pt, example_pt - Model: gpt-5.5, SequentialChunks (6), function calling - Enabled = false (requires manual activation + API key) Part of #411 Cat B — i18n cosmetic polish via DatasetUpdater. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
[NanoClaw]
Straightforward config addition. Verified against the two existing PT register tasks (Virtues, Scenarii) and the broader Fallacies dataset config block.
Checks passed:
- Pattern is a 1:1 copy of the Virtues/Scenarii PT register entries -- same model, chunk size, tokens, function calling, compare mode, prompt paths, all structural params
SourceDataset = KnownDataSets.FallaciesTaxonomy-- consistent with 11 other Fallacies tasks in the file- Field names (
text_pt,desc_pt,example_pt) match the established Fallacies PT columns (lines 350-432 in master) - Context fields (
path,text_fr,text_en) match every other Fallacies task TargetPath=Argumentum Fallacies - Taxonomy.csv-- matches all Fallacies tasksEnabled = false-- safe default, won't run without explicit activation- Prompt files (
PromptCosmeticPolishPtRegisterUser.txt/Assistant.txt) are shared across all 3 PT register tasks, already in place - No credentials, no hardcoded secrets, no injection risk
- 1 file, +49 lines, zero deletions -- minimal blast radius
No issues found. Ready to merge.
jsboige
added a commit
that referenced
this pull request
Jun 7, 2026
…447) Add DatasetUpdater config for Fallacies taxonomy PT register harmonization. Matches existing Virtues/Scenarii PT register task pattern: - Fields: text_pt, desc_pt, example_pt - Model: gpt-5.5, SequentialChunks (6), function calling - Enabled = false (requires manual activation + API key) Part of #411 Cat B — i18n cosmetic polish via DatasetUpdater. Co-authored-by: Your <your.email@example.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
3 tasks
jsboige
added a commit
that referenced
this pull request
Jun 15, 2026
…α resubmit) (#484) Re-submit the α deliverable from #444 (closed stale) as a clean doc-only PR. The original #444 bundled α (this assessment) + β (Memo Back loc fix = #446) + γ (gpt-5.5 PT task = #447). β and γ are already on master; γ additionally carried a parasite gpt-5.5→5.4-mini downgrade on 12 sites (avoided). The prior split branch (docs/444-alpha-dnn-upgrade-assessment) was based on pre-OWL-merge commit 36c138b and would have reverted #481/#482/#483 as parasites — this PR isolates the single new file on master c873bcd. Related: #131 (DNN security/upgrade), #132 (DNN deployment), #134 (release v0.9.0). Supersedes: #444 (closed stale; β=#446, γ=#447 already merged). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
DatasetUpdaterConfigentry for Fallacies taxonomy PT register harmonization — the last of the 3 datasets (Virtues ✅, Scenarii ✅, Fallacies 🔜).Changes
"Fallacies cosmetic polish PT register gpt-5.5"inDatasetUpdaterRootConfig.cs(lines 2587-2635)text_pt,desc_pt,example_pt(3 PT text columns to polish)path,text_fr,text_en(for LLM reference)Enabled = false— requires manual activation + OpenAI API keyPattern
Exact same config as existing Virtues/Scenarii PT register tasks:
gpt-5.5SequentialChunkswithChunkSize = 6UpdateRecordtool)AutoCompare = truePromptCosmeticPolishPtRegisterUser.txt/Assistant.txtValidation
dotnet build— 0 errorsdotnet test— 151 pass, 0 fail, 5 skipRelated
Post-merge
jsboige needs to:
Enabled = trueSkipChunkNb = 0, TakeChunkNb = 2)AutoCompareoutput before full run